Skip to content

Commit 89e5a3a

Browse files
committed
We should always run tests where we have no opinion on their gate
1 parent 89c53ef commit 89e5a3a

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

pkg/clioptions/suiteselection/feature_filter.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,11 @@ func (f *featureGateFilter) includeTest(name string) bool {
7070
return false
7171
}
7272

73-
return f.enabled.HasAll(featureGates...)
73+
// It is important that we always return true if we don't know the status of the gate.
74+
// This generally means we have no opinion on whether the feature is on or off.
75+
// We expect the default case to be on, as this is what would happen after a feature is promoted,
76+
// and the gate is removed.
77+
return true
7478
}
7579

7680
func includeNonFeatureGateTest(name string) bool {

0 commit comments

Comments
 (0)