Skip to content

Conversation

@machine424
Copy link
Contributor

No description provided.

policy := metav1.DeletePropagationForeground
for _, worker := range b.extraWorkers {
err := b.bmcClient.Delete(context.Background(), worker.GetName(), metav1.DeleteOptions{})
err := b.bmcClient.Delete(context.Background(), worker.GetName(), metav1.DeleteOptions{PropagationPolicy: &policy})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming the controller implements it, let's see.

@openshift-ci openshift-ci bot requested review from deads2k and sjenning September 4, 2025 13:48
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: machine424
Once this PR has been reviewed and has the lgtm label, please assign elfosardo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@machine424
Copy link
Contributor Author

/payload-aggregate periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-serial-virtualmedia-2of2 10

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2025

@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-serial-virtualmedia-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/101b7b80-899e-11f0-9f11-73faed7ea00c-0

@machine424 machine424 changed the title test(baremetal/helper.go): use DeletePropagationForeground policy while deleting CRs to avoid leftovers WIP: test(baremetal/helper.go): use DeletePropagationForeground policy while deleting CRs to avoid leftovers Sep 5, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2025

@machine424: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-csi dd34c30 link true /test e2e-aws-csi
ci/prow/e2e-gcp-csi dd34c30 link true /test e2e-gcp-csi
ci/prow/go-verify-deps dd34c30 link true /test go-verify-deps
ci/prow/e2e-metal-ipi-ovn-ipv6 dd34c30 link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant