OCPBUGS-46422: Add test that the ServiceCIDR API is blocked [4.20] #30434
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@danwinship: This pull request references Jira Issue OCPBUGS-46422, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
danwinship
force-pushed
the
servicecidr-4.20
branch
from
8860509 to
88f25ed
Compare
|
/retest |
openshift-ci-robot
added
the
verified
|
@danwinship: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-vsphere-ovn |
|
/assign @kyrtapz |
|
/lgtm |
|
/assign @bertinatto ah needs an approve too. (Last one!) |
bertinatto
left a comment
bertinatto
left a comment
There was a problem hiding this comment.
I just added 2 minor questions, so I'm approving the PR and adding a hold tag in case you want to add changes before merging. If not, feel free to remove the hold and let the PR merge.
/approve
/hold
| @@ -0,0 +1,7 @@ | |||
| apiVersion: networking.k8s.io/v1beta1 | |||
There was a problem hiding this comment.
Don't we have a v1 resource in 4.20?
There was a problem hiding this comment.
oh, yes... I must have copied this example from old docs or something. Anyway, specifying v1beta1 still works, and this is just a backport from main so we shouldn't fix it here anyway...
| o.Expect(err).To(o.HaveOccurred(), "Creating a ServiceCIDR should have been blocked by ValidatingAdmissionPolicy") | ||
|
|
||
| g.By("Trying to modify an existing ServiceCIDR") | ||
| err = oc.AsAdmin().Run("annotate").Args("servicecidr", "kubernetes", "e2etest=success").Execute() |
There was a problem hiding this comment.
Just for my understanding, I assume this is created by default in k8s, is that right?
There was a problem hiding this comment.
yes, the kubernetes ServiceCIDR is created by the apiserver, just like the kubernetes Service.
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, danwinship, kyrtapz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold cancel I should fix the |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Scheduling required tests: |
|
Scheduling required tests: |
|
@danwinship: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 0a0905d
into
openshift:release-4.20
|
@danwinship: Jira Issue OCPBUGS-46422: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-46422 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in accepted release 4.20.0-0.nightly-2025-11-22-184222 |
5 participants
backport of #30234
This won't pass until openshift/cluster-network-operator#2827 merges, but it can still be reviewed before then