Skip to content

[NFV] Added IPV6 scenarios for NFV #3476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mnietoji wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[NFV] Added IPV6 scenarios for NFV #3476

mnietoji wants to merge 1 commit into from

Conversation

@mnietoji
Copy link
Contributor

@mnietoji mnietoji commented Nov 12, 2025 •
edited
Loading 

[multiple] Added IPv6 scenarios for NFV with OVS-DPDK and SR-IOV

Added two new IPv6 deployment scenarios:
* OVS-DPDK SR-IOV with 1 nodeset (va-nfv-ovs-dpdk-sriov-ipv6.yml)
* OVS-DPDK SR-IOV with 2 nodesets (dt-nfv-ovs-dpdk-sriov-ipv6-2nodesets.yml)

[build_openstack_packages] Added IPv6 nodeset templates
  * Added edpm-nodeset-values template with IPv6 configuration
  * Added edpm-nodeset2-values template for dual nodeset deployments
  * Updated common network-values template for IPv6 support

[networking_mapper] Fixed IPv6 address formatting
  * Updated generate_networking_data.yml to properly handle IPv6 addresses
  * Prevented bracket corruption when IPv6 addresses are embedded in YAML

[nat64_appliance] Extended NAT64/DNS64 support
  * Added cifmw_nat64_appliance_upstream_dns parameter for custom DNS
  * Enhanced cleanup task to properly handle NAT64 network deletion
  * Improved main task to configure DNS64 with custom upstream resolvers

@mnietoji mnietoji requested a review from a team as a code owner November 12, 2025 10:22
@mnietoji mnietoji marked this pull request as draft November 12, 2025 10:23
@mnietoji mnietoji force-pushed the nfv_ipv6 branch 12 times, most recently from 08a221c to 32f0eda Compare November 14, 2025 17:45
hjensas
hjensas requested changes Nov 17, 2025
View reviewed changes
@mnietoji mnietoji force-pushed the nfv_ipv6 branch 5 times, most recently from 2d1f22f to c3c5b3f Compare November 21, 2025 10:38
@mnietoji mnietoji changed the title ipv6 [NFV] Added IPV6 scenarios for NFV Nov 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tosky for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 25, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/17b3bc675b1c41ec9ec0535494b774a2

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 40s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 23m 53s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 53m 30s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 37s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 51s
✔️ cifmw-pod-k8s-snippets-source SUCCESS in 4m 37s
✔️ cifmw-pod-pre-commit SUCCESS in 9m 41s
✔️ cifmw-architecture-validate-hci SUCCESS in 6m 29s
✔️ build-push-container-cifmw-client SUCCESS in 24m 26s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 44s
✔️ cifmw-molecule-libvirt_manager SUCCESS in 39m 07s
✔️ cifmw-molecule-reproducer SUCCESS in 15m 34s

@mnietoji mnietoji force-pushed the nfv_ipv6 branch 2 times, most recently from 8a0b378 to c87aaa9 Compare November 26, 2025 18:48
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 26, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fe597dd8a8ff4522bd9df7850eb7be90

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 44s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 9m 07s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 28m 21s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 57s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 29s
✔️ cifmw-pod-k8s-snippets-source SUCCESS in 4m 22s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 44s
✔️ cifmw-architecture-validate-hci SUCCESS in 4m 16s
✔️ build-push-container-cifmw-client SUCCESS in 19m 28s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 37s
✔️ cifmw-molecule-dnsmasq SUCCESS in 4m 50s
✔️ cifmw-molecule-libvirt_manager SUCCESS in 39m 39s
✔️ cifmw-molecule-nat64_appliance SUCCESS in 15m 55s
✔️ cifmw-molecule-reproducer SUCCESS in 15m 37s

@mnietoji mnietoji force-pushed the nfv_ipv6 branch 2 times, most recently from 4234e3f to 8db13f0 Compare November 27, 2025 23:29
@mnietoji
Copy link
Contributor Author

mnietoji commented Dec 5, 2025

recheck

@mnietoji
[multiple] Added IPv6 scenarios for NFV with OVS-DPDK and SR-IOV
73ea9cc 
Added two new IPv6 deployment scenarios:
* OVS-DPDK SR-IOV with 1 nodeset (va-nfv-ovs-dpdk-sriov-ipv6.yml)
* OVS-DPDK SR-IOV with 2 nodesets (dt-nfv-ovs-dpdk-sriov-ipv6-2nodesets.yml)

[build_openstack_packages] Added IPv6 nodeset templates
  * Added edpm-nodeset-values template with IPv6 configuration
  * Added edpm-nodeset2-values template for dual nodeset deployments
  * Updated common network-values template for IPv6 support

[networking_mapper] Fixed IPv6 address formatting
  * Updated generate_networking_data.yml to properly handle IPv6 addresses
  * Prevented bracket corruption when IPv6 addresses are embedded in YAML

[nat64_appliance] Extended NAT64/DNS64 support
  * Added cifmw_nat64_appliance_upstream_dns parameter for custom DNS
  * Enhanced cleanup task to properly handle NAT64 network deletion
  * Improved main task to configure DNS64 with custom upstream resolvers

Signed-off-by: Miguel Angel Nieto Jimenez <[email protected]>
@mnietoji mnietoji mentioned this pull request Dec 5, 2025
Open
@mnietoji mnietoji marked this pull request as ready for review December 5, 2025 11:16
hjensas
hjensas reviewed Dec 5, 2025
View reviewed changes
roles/nat64_appliance/defaults/main.yml
cifmw_nat64_appliance_memory: 2
cifmw_nat64_appliance_cpus: 2
cifmw_nat64_appliance_ssh_pub_keys: []

Copy link
Contributor

@hjensas hjensas Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message states:

[nat64_appliance] Extended NAT64/DNS64 support

  • Added cifmw_nat64_appliance_upstream_dns parameter for custom DNS
  • Enhanced cleanup task to properly handle NAT64 network deletion
  • Improved main task to configure DNS64 with custom upstream resolvers

I don't see the upstream resolver parameters changes?

Also, a request, can you propose the changes to the nat64_appliance role separately?
Major ++ on adding the option to pull a pre-built image! 💯

A suggestion, instead of a multitude of tasks that are skipped can we move all the tasks to build the image to a separate task file and conditionally include that? Or use an ansible block?

Copy link
Contributor Author

@mnietoji mnietoji Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that comment is outdated, not doing anything like that here.
Ok, i will take nat64 changes to a different PR and I will include your suggestion

@evallesp
Copy link
Contributor

evallesp commented Dec 5, 2025

LGTM in general. Agree with @hjensas suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hjensas hjensas hjensas requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Ready For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mnietoji @evallesp @hjensas