fix: test no longer triggers subsidy so test logic was wrong

Author: 0xcacti

pallets/subtensor/src/coinbase/run_coinbase.rs

@@ -76,10 +76,10 @@ impl<T: Config> Pallet<T> {
             log::debug!("default_alpha_in_i: {default_alpha_in_i:?}");
 
             // Get alpha_emission total
-            let alpha_emission_i: U96F32 = asfloat!(Self::get_block_emission_for_issuance(
-                Self::get_alpha_issuance(*netuid_i).into()
-            )
-            .unwrap_or(0));
+            let alpha_emission_i: U96F32 = asfloat!(
+                Self::get_block_emission_for_issuance(Self::get_alpha_issuance(*netuid_i).into())
+                    .unwrap_or(0)
+            );
             log::debug!("alpha_emission_i: {alpha_emission_i:?}");
 
             let mut alpha_in_i: U96F32;
@@ -92,11 +92,7 @@ impl<T: Config> Pallet<T> {
                 alpha_in_i = min_alpha_emission;
                 tao_in_i = alpha_in_i.saturating_mul(price_i);
 
-                println!("are we in this block?");
-                println!("total_moving_prices: {total_moving_prices:?}");
-
                 if total_moving_prices < U96F32::saturating_from_num(1.0) {
-                    println!("my favorite bar is če");
                     let difference_tao: U96F32 = default_tao_in_i.saturating_sub(tao_in_i);
                     // Difference becomes buy.
                     let buy_swap_result = Self::swap_tao_for_alpha(
@@ -232,7 +228,7 @@ impl<T: Config> Pallet<T> {
             let root_alpha: U96F32 = root_proportion
                 .saturating_mul(alpha_out_i) // Total alpha emission per block remaining.
                 .saturating_mul(asfloat!(0.5)); // 50% to validators.
-                                                // Remove root alpha from alpha_out.
+            // Remove root alpha from alpha_out.
             log::debug!("root_alpha: {root_alpha:?}");
             // Get pending alpha as original alpha_out - root_alpha.
             let pending_alpha: U96F32 = alpha_out_i.saturating_sub(root_alpha);

pallets/subtensor/src/tests/coinbase.rs

@@ -463,8 +463,8 @@ fn test_coinbase_alpha_issuance_with_cap_trigger_and_block_emission() {
         // Enable emission
         FirstEmissionBlockNumber::<Test>::insert(netuid1, 0);
         FirstEmissionBlockNumber::<Test>::insert(netuid2, 0);
-        SubnetMovingPrice::<Test>::insert(netuid1, I96F32::from_num(1));
-        SubnetMovingPrice::<Test>::insert(netuid2, I96F32::from_num(2));
+        SubnetMovingPrice::<Test>::insert(netuid1, I96F32::from_num(0.1));
+        SubnetMovingPrice::<Test>::insert(netuid2, I96F32::from_num(0.2));
 
         // Force the swap to initialize
         SubtensorModule::swap_tao_for_alpha(
@@ -498,7 +498,7 @@ fn test_coinbase_alpha_issuance_with_cap_trigger_and_block_emission() {
         let price_2_after = <Test as pallet::Config>::SwapInterface::current_alpha_price(netuid2);
 
         // AlphaIn gets decreased beacuse of a buy
-        assert!(u64::from(SubnetAlphaIn::<Test>::get(netuid1)) < initial_alpha);
+        assert!(u64::from(SubnetAlphaIn::<Test>::get(netuid1)) < initial_alpha); // HERE
         assert_eq!(
             u64::from(SubnetAlphaOut::<Test>::get(netuid2)),
             21_000_000_000_000_000_u64