Use metadata to determine namespace in args (#2072)

Use an env to get the metadata.namespace, and then use a variable
in the arguments to get the value. Avoids putting the namespace
into the manifest.

Signed-off-by: Todd Short <[email protected]>

Author: tmshort

config/base/catalogd/manager/manager.yaml

@@ -46,7 +46,12 @@ spec:
         args:
         - --leader-elect
         - --metrics-bind-address=:7443
-        - --external-address=catalogd-service.olmv1-system.svc
+        - --external-address=catalogd-service.$(POD_NAMESPACE).svc
+        env:
+          - name: POD_NAMESPACE
+            valueFrom:
+              fieldRef:
+                fieldPath: metadata.namespace
         image: controller:latest
         name: manager
         volumeMounts:

manifests/experimental-e2e.yaml

@@ -1653,7 +1653,7 @@ spec:
       - args:
         - --leader-elect
         - --metrics-bind-address=:7443
-        - --external-address=catalogd-service.olmv1-system.svc
+        - --external-address=catalogd-service.$(POD_NAMESPACE).svc
         - --feature-gates=APIV1MetasHandler=true
         - --tls-cert=/var/certs/tls.crt
         - --tls-key=/var/certs/tls.key
@@ -1663,6 +1663,10 @@ spec:
         env:
         - name: GOCOVERDIR
           value: /e2e-coverage
+        - name: POD_NAMESPACE
+          valueFrom:
+            fieldRef:
+              fieldPath: metadata.namespace
         image: quay.io/operator-framework/catalogd:devel
         imagePullPolicy: IfNotPresent
         livenessProbe:

manifests/experimental.yaml

@@ -1626,13 +1626,18 @@ spec:
       - args:
         - --leader-elect
         - --metrics-bind-address=:7443
-        - --external-address=catalogd-service.olmv1-system.svc
+        - --external-address=catalogd-service.$(POD_NAMESPACE).svc
         - --feature-gates=APIV1MetasHandler=true
         - --tls-cert=/var/certs/tls.crt
         - --tls-key=/var/certs/tls.key
         - --pull-cas-dir=/var/ca-certs
         command:
         - ./catalogd
+        env:
+        - name: POD_NAMESPACE
+          valueFrom:
+            fieldRef:
+              fieldPath: metadata.namespace
         image: quay.io/operator-framework/catalogd:devel
         imagePullPolicy: IfNotPresent
         livenessProbe:

manifests/standard-e2e.yaml

@@ -1646,7 +1646,7 @@ spec:
       - args:
         - --leader-elect
         - --metrics-bind-address=:7443
-        - --external-address=catalogd-service.olmv1-system.svc
+        - --external-address=catalogd-service.$(POD_NAMESPACE).svc
         - --tls-cert=/var/certs/tls.crt
         - --tls-key=/var/certs/tls.key
         - --pull-cas-dir=/var/ca-certs
@@ -1655,6 +1655,10 @@ spec:
         env:
         - name: GOCOVERDIR
           value: /e2e-coverage
+        - name: POD_NAMESPACE
+          valueFrom:
+            fieldRef:
+              fieldPath: metadata.namespace
         image: quay.io/operator-framework/catalogd:devel
         imagePullPolicy: IfNotPresent
         livenessProbe:

manifests/standard.yaml

@@ -1619,12 +1619,17 @@ spec:
       - args:
         - --leader-elect
         - --metrics-bind-address=:7443
-        - --external-address=catalogd-service.olmv1-system.svc
+        - --external-address=catalogd-service.$(POD_NAMESPACE).svc
         - --tls-cert=/var/certs/tls.crt
         - --tls-key=/var/certs/tls.key
         - --pull-cas-dir=/var/ca-certs
         command:
         - ./catalogd
+        env:
+        - name: POD_NAMESPACE
+          valueFrom:
+            fieldRef:
+              fieldPath: metadata.namespace
         image: quay.io/operator-framework/catalogd:devel
         imagePullPolicy: IfNotPresent
         livenessProbe: