Skip to content

Commit c5f8b8e

Browse files
committed
refactoring code
1 parent ed4ce52 commit c5f8b8e

File tree

1 file changed

+5
-14
lines changed

1 file changed

+5
-14
lines changed

oracle/migrator.go

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -484,32 +484,23 @@ func (m Migrator) DropConstraint(value interface{}, name string) error {
484484
return m.Migrator.DropConstraint(value, name)
485485
}
486486

487-
// CreateType creates or replaces an Oracle user-defined type.
487+
// CreateType creates or replaces an Oracle user-defined type
488488
func (m Migrator) CreateType(typeName, typeKind, typeof string) error {
489489
if typeName == "" || typeKind == "" || typeof == "" {
490-
return fmt.Errorf("CreateOracleType: both typeName and definition are required")
490+
return fmt.Errorf("createType: both typeName and definition are required")
491491
}
492492

493493
sql := fmt.Sprintf(`CREATE OR REPLACE TYPE "%s" AS %s OF %s`, strings.ToLower(typeName), typeKind, typeof)
494494
return m.DB.Exec(sql).Error
495495
}
496496

497-
// DropType drops an Oracle user-defined type safely.
497+
// DropType drops an Oracle user-defined type
498498
func (m Migrator) DropType(typeName string) error {
499-
sql := fmt.Sprintf(`
500-
BEGIN
501-
EXECUTE IMMEDIATE 'DROP TYPE "%s" FORCE';
502-
EXCEPTION
503-
WHEN OTHERS THEN
504-
IF SQLCODE != -4043 THEN
505-
RAISE;
506-
END IF;
507-
END;`, strings.ToLower(typeName))
508-
499+
sql := fmt.Sprintf(`DROP TYPE "%s" FORCE`, strings.ToLower(typeName))
509500
return m.DB.Exec(sql).Error
510501
}
511502

512-
// HasType checks whether a user-defined type exists in Oracle.
503+
// HasType checks whether a user-defined type exists
513504
func (m Migrator) HasType(typeName string) bool {
514505
if typeName == "" {
515506
return false

0 commit comments

Comments
 (0)