main: add regression test for aws upload target arch error

This is a regression test to ensure the commandline handling
of aws upload is correct. Its a followup for
#1030

Author: mvo5

bib/cmd/bootc-image-builder/export_test.go

@@ -1,5 +1,10 @@
 package main
 
+import (
+	"github.com/osbuild/images/pkg/cloud"
+	"github.com/osbuild/images/pkg/cloud/awscloud"
+)
+
 var (
 	CanChownInPath                = canChownInPath
 	CheckFilesystemCustomizations = checkFilesystemCustomizations
@@ -11,6 +16,7 @@ var (
 	CreateRand                    = createRand
 	BuildCobraCmdline             = buildCobraCmdline
 	CalcRequiredDirectorySizes    = calcRequiredDirectorySizes
+	HandleAWSFlags                = handleAWSFlags
 )
 
 func MockOsGetuid(new func() int) (restore func()) {
@@ -28,3 +34,11 @@ func MockOsReadFile(new func(string) ([]byte, error)) (restore func()) {
 		osReadFile = saved
 	}
 }
+
+func MockAwscloudNewUploader(f func(string, string, string, *awscloud.UploaderOptions) (cloud.Uploader, error)) (restore func()) {
+	saved := awscloudNewUploader
+	awscloudNewUploader = f
+	return func() {
+		awscloudNewUploader = saved
+	}
+}

bib/cmd/bootc-image-builder/main.go

@@ -371,6 +371,8 @@ func cmdManifest(cmd *cobra.Command, args []string) error {
 	return nil
 }
 
+var awscloudNewUploader = awscloud.NewUploader
+
 func handleAWSFlags(cmd *cobra.Command) (cloud.Uploader, error) {
 	imgTypes, _ := cmd.Flags().GetStringArray("type")
 	region, _ := cmd.Flags().GetString("aws-region")
@@ -385,7 +387,6 @@ func handleAWSFlags(cmd *cobra.Command) (cloud.Uploader, error) {
 		return nil, fmt.Errorf("aws flags set for non-ami image type (type is set to %s)", strings.Join(imgTypes, ","))
 	}
 
-	// check as many permission prerequisites as possible before starting
 	targetArch := arch.Current()
 	if targetArchStr != "" {
 		var err error
@@ -397,14 +398,15 @@ func handleAWSFlags(cmd *cobra.Command) (cloud.Uploader, error) {
 	uploaderOpts := &awscloud.UploaderOptions{
 		TargetArch: targetArch,
 	}
-	uploader, err := awscloud.NewUploader(region, bucketName, imageName, uploaderOpts)
+	uploader, err := awscloudNewUploader(region, bucketName, imageName, uploaderOpts)
 	if err != nil {
 		return nil, err
 	}
 	status := io.Discard
 	if logrus.GetLevel() >= logrus.InfoLevel {
 		status = os.Stderr
 	}
+	// check as many permission prerequisites as possible before starting
 	if err := uploader.Check(status); err != nil {
 		return nil, err
 	}

bib/cmd/bootc-image-builder/main_test.go

@@ -1,9 +1,11 @@
 package main_test
 
 import (
+	"bytes"
 	"encoding/json"
 	"errors"
 	"fmt"
+	"io"
 	"os"
 	"strings"
 	"testing"
@@ -17,6 +19,8 @@ import (
 	"github.com/osbuild/blueprint/pkg/blueprint"
 	"github.com/osbuild/images/pkg/arch"
 	"github.com/osbuild/images/pkg/bib/osinfo"
+	"github.com/osbuild/images/pkg/cloud"
+	"github.com/osbuild/images/pkg/cloud/awscloud"
 	"github.com/osbuild/images/pkg/container"
 	"github.com/osbuild/images/pkg/dnfjson"
 	"github.com/osbuild/images/pkg/manifest"
@@ -631,3 +635,68 @@ func TestCobraCmdlineVerbose(t *testing.T) {
 		})
 	}
 }
+
+type fakeAwsUploader struct {
+	checkCalls int
+
+	region, bucket, ami string
+	opts                *awscloud.UploaderOptions
+
+	uploadAndRegisterRead  bytes.Buffer
+	uploadAndRegisterCalls int
+	uploadAndRegisterErr   error
+}
+
+var _ = cloud.Uploader(&fakeAwsUploader{})
+
+func (fa *fakeAwsUploader) Check(status io.Writer) error {
+	fa.checkCalls++
+	return nil
+}
+
+func (fa *fakeAwsUploader) UploadAndRegister(r io.Reader, status io.Writer) error {
+	fa.uploadAndRegisterCalls++
+	_, err := io.Copy(&fa.uploadAndRegisterRead, r)
+	if err != nil {
+		panic(err)
+	}
+	return fa.uploadAndRegisterErr
+}
+
+func TestHandleAWSFlags(t *testing.T) {
+
+	for _, tc := range []struct {
+		extraArgs    []string
+		expectedOpts *awscloud.UploaderOptions
+	}{
+		{nil, &awscloud.UploaderOptions{TargetArch: arch.Current()}},
+		{[]string{"--target-arch=aarch64"}, &awscloud.UploaderOptions{TargetArch: arch.ARCH_AARCH64}},
+	} {
+		var fau fakeAwsUploader
+		t.Cleanup(main.MockAwscloudNewUploader(func(region string, bucket string, ami string, opts *awscloud.UploaderOptions) (cloud.Uploader, error) {
+			fau.region = region
+			fau.bucket = bucket
+			fau.ami = ami
+			fau.opts = opts
+			return &fau, nil
+		}))
+
+		rootCmd, err := main.BuildCobraCmdline()
+		assert.NoError(t, err)
+		// Commands() returns commandsordered by name
+		buildCmd := rootCmd.Commands()[0]
+		assert.Equal(t, "build", buildCmd.Name())
+		buildCmd.ParseFlags(append([]string{
+			"--aws-bucket=aws-bucket",
+			"--aws-ami-name=aws-ami-name",
+			"--aws-region=aws-region",
+			"--type=ami",
+		}, tc.extraArgs...))
+
+		uploader, err := main.HandleAWSFlags(buildCmd)
+		assert.NoError(t, err)
+		assert.NotNil(t, uploader)
+		assert.Equal(t, 1, fau.checkCalls)
+		assert.Equal(t, tc.expectedOpts, fau.opts)
+	}
+}