fix: make packages search respect chosen date

This fixes an issue with the 'Packages' step where you could pick
additional packages that might not be available in the included
repositories at the chosen snapshot date, or ones that were removed.
This would be very complicated to do solely in this frontend so the
names search APIs were extended to support a date argument and search
the correct snapshots for the content when that's provided.

Author: dominikvagner

src/Components/CreateImageWizard/steps/Packages/Packages.tsx

@@ -93,6 +93,7 @@ import {
   selectModules,
   selectPackages,
   selectRecommendedRepositories,
+  selectSnapshotDate,
   selectTemplate,
 } from '../../../../store/wizardSlice';
 import {
@@ -101,6 +102,7 @@ import {
   getEpelVersionForDistribution,
 } from '../../../../Utilities/epel';
 import useDebounce from '../../../../Utilities/useDebounce';
+import { convertStringToDate } from '../../../../Utilities/time';
 
 export type PackageRepository = 'distro' | 'custom' | 'recommended' | '';
 
@@ -144,6 +146,7 @@ const Packages = () => {
   const groups = useAppSelector(selectGroups);
   const modules = useAppSelector(selectModules);
   const template = useAppSelector(selectTemplate);
+  const snapshotDate = useAppSelector(selectSnapshotDate);
 
   const { data: templateData } = useGetTemplateQuery({
     uuid: template,
@@ -298,6 +301,7 @@ const Packages = () => {
                     ),
             limit: 500,
             include_package_sources: true,
+            date: !!snapshotDate ? new Date(convertStringToDate(snapshotDate)).toISOString() : undefined,
           },
         });
       }
@@ -312,13 +316,15 @@ const Packages = () => {
             }),
             limit: 500,
             include_package_sources: true,
+            date: !!snapshotDate ? new Date(convertStringToDate(snapshotDate)).toISOString() : undefined,
           },
         });
       } else {
         searchRecommendedRpms({
           apiContentUnitSearchRequest: {
             search: debouncedSearchTerm,
             urls: [epelRepoUrlByDistribution],
+            date: !!snapshotDate ? new Date(convertStringToDate(snapshotDate)).toISOString() : undefined,
           },
         });
       }
@@ -337,6 +343,7 @@ const Packages = () => {
     template,
     distribution,
     debouncedSearchTermIsGroup,
+    snapshotDate,
   ]);
 
   useEffect(() => {
@@ -346,7 +353,7 @@ const Packages = () => {
     if (isSuccessDistroRepositories) {
       searchDistroGroups({
         apiContentUnitSearchRequest: {
-          search: debouncedSearchTerm.substr(1),
+          search: debouncedSearchTerm.substring(1),
           urls: distroRepositories
             ?.filter((archItem) => {
               return archItem.arch === arch;
@@ -357,23 +364,26 @@ const Packages = () => {
               }
               return repo.baseurl;
             }),
+            date: !!snapshotDate ? new Date(convertStringToDate(snapshotDate)).toISOString() : undefined,
         },
       });
     }
     if (activeTabKey === Repos.INCLUDED && customRepositories.length > 0) {
       searchCustomGroups({
         apiContentUnitSearchRequest: {
-          search: debouncedSearchTerm.substr(1),
+          search: debouncedSearchTerm.substring(1),
           uuids: customRepositories.flatMap((repo) => {
             return repo.id;
           }),
+          date: !!snapshotDate ? new Date(convertStringToDate(snapshotDate)).toISOString() : undefined,
         },
       });
     } else if (activeTabKey === Repos.OTHER && isSuccessEpelRepo) {
       searchRecommendedGroups({
         apiContentUnitSearchRequest: {
-          search: debouncedSearchTerm.substr(1),
+          search: debouncedSearchTerm.substring(1),
           urls: [epelRepoUrlByDistribution],
+          date: !!snapshotDate ? new Date(convertStringToDate(snapshotDate)).toISOString() : undefined,
         },
       });
     }
@@ -390,6 +400,7 @@ const Packages = () => {
     distroRepositories,
     isSuccessDistroRepositories,
     isSuccessEpelRepo,
+    snapshotDate,
   ]);
 
   const EmptySearch = () => {
@@ -1438,6 +1449,7 @@ const Packages = () => {
     toggleSelected,
     activeTabKey,
     transformedPackages,
+    transformedGroups,
     isSelectingPackage,
     recommendedRepositories,
     transformedPackages.length,

src/store/service/contentSourcesApi.ts

@@ -254,6 +254,8 @@ export type ErrorsErrorResponse = {
   errors?: ErrorsHandlerError[] | undefined;
 };
 export type ApiContentUnitSearchRequest = {
+  /** Optional date to search in dated snapshots of the listed repositories. */
+  date?: string | undefined;
   /** List of names to search using an exact match */
   exact_names?: string[] | undefined;
   /** Whether to include module information */