Skip to content

Commit 976f005

Browse files
croissannethozza
authored andcommitted
cloud/aws: unit tests for extra security group logic
1 parent be46ac2 commit 976f005

File tree

2 files changed

+29
-0
lines changed

2 files changed

+29
-0
lines changed

internal/cloud/awscloud/mocks_test.go

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,13 @@ func newEc2Mock(t *testing.T) *ec2mock {
4949
}
5050
}
5151

52+
func (m *ec2mock) AuthorizeSecurityGroupEgress(ctx context.Context, input *ec2.AuthorizeSecurityGroupEgressInput, optfns ...func(*ec2.Options)) (*ec2.AuthorizeSecurityGroupEgressOutput, error) {
53+
m.calledFn["AuthorizeSecurityGroupEgress"] += 1
54+
return &ec2.AuthorizeSecurityGroupEgressOutput{
55+
Return: aws.Bool(true),
56+
}, nil
57+
}
58+
5259
func (m *ec2mock) AuthorizeSecurityGroupIngress(ctx context.Context, input *ec2.AuthorizeSecurityGroupIngressInput, optfns ...func(*ec2.Options)) (*ec2.AuthorizeSecurityGroupIngressOutput, error) {
5360
m.calledFn["AuthorizeSecurityGroupIngress"] += 1
5461
return &ec2.AuthorizeSecurityGroupIngressOutput{
@@ -90,6 +97,25 @@ func (m *ec2mock) DescribeSecurityGroups(ctx context.Context, input *ec2.Describ
9097
}, nil
9198
}
9299

100+
func (m *ec2mock) DescribeSecurityGroupRules(ctx context.Context, input *ec2.DescribeSecurityGroupRulesInput, optfns ...func(*ec2.Options)) (*ec2.DescribeSecurityGroupRulesOutput, error) {
101+
m.calledFn["DescribeSecurityGroupRules"] += 1
102+
return &ec2.DescribeSecurityGroupRulesOutput{
103+
SecurityGroupRules: []ec2types.SecurityGroupRule{
104+
{
105+
IsEgress: aws.Bool(true),
106+
SecurityGroupRuleId: aws.String("sgr-id"),
107+
},
108+
},
109+
}, nil
110+
}
111+
112+
func (m *ec2mock) RevokeSecurityGroupEgress(ctx context.Context, input *ec2.RevokeSecurityGroupEgressInput, optfns ...func(*ec2.Options)) (*ec2.RevokeSecurityGroupEgressOutput, error) {
113+
m.calledFn["RevokeSecurityGroupEgress"] += 1
114+
return &ec2.RevokeSecurityGroupEgressOutput{
115+
Return: aws.Bool(true),
116+
}, nil
117+
}
118+
93119
func (m *ec2mock) CreateSubnet(ctx context.Context, input *ec2.CreateSubnetInput, optfns ...func(*ec2.Options)) (*ec2.CreateSubnetOutput, error) {
94120
m.calledFn["CreateSubnet"] += 1
95121
return nil, nil

internal/cloud/awscloud/secure-instance_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,9 @@ func TestSIRunSecureInstance(t *testing.T) {
7171
require.Equal(t, 1, m.calledFn["CreateFleet"])
7272
require.Equal(t, 1, m.calledFn["CreateSecurityGroup"])
7373
require.Equal(t, 1, m.calledFn["CreateLaunchTemplate"])
74+
require.Equal(t, 1, m.calledFn["AuthorizeSecurityGroupEgress"])
75+
require.Equal(t, 1, m.calledFn["AuthorizeSecurityGroupIngress"])
76+
require.Equal(t, 1, m.calledFn["RevokeSecurityGroupEgress"])
7477
}
7578

7679
func TestSITerminateSecureInstance(t *testing.T) {

0 commit comments

Comments
 (0)