Tool versions used by the analyzer should be recorded as part of project results

[sschuberth]

This is the respective issue for the analyzer that has been fixed for the scanner here:

ort/analyzer/src/main/kotlin/Analyzer.kt

Lines 153 to 161 in 927e47c

	val toolVersions = mutableMapOf<String, String>()
	info.managedFiles.keys.forEach { manager ->
	if (manager is CommandLineTool) {
	toolVersions[manager.descriptor.id] = manager.getVersion()
	}
	}
	val run = AnalyzerRun(startTime, endTime, Environment(toolVersions = toolVersions), config, analyzerResult)

The above code does not work anymore as expected because PackageManagers do not implement CommandLineTool anymore, in favor of having command objects that implement CommandLineTool.

I'm not currently having a good idea how to fix this, so maybe @oss-review-toolkit/kotlin-devs have? Of course, we could extend PackageManager with somehting like a nullable getCommandLineTool() or so, but that doesn't seem to be very elegant...

Should we maybe stop tracking the analyzer tool version completely? After all, no one seems to have missed them while the above code was broken...

[sschuberth]

Maybe it'd be better to record the tool version as part of ProjectAnalyzerResult, as some package managers theoretically could use different tool versions per project, like Node projects with corepack enabled.

[mnonnenmacher]

I like the idea of storing the version by project but I'm not sure where to put that information. ProjectAnalyzerResult is only used at runtime, so it could be stored either in the Project itself or AnalyzerResult would need some separate property to associate projects with tool versions.