From 1a8be4e233e068f593730b28803bf510a17d0d3e Mon Sep 17 00:00:00 2001 From: Nick Schmeller Date: Tue, 19 Aug 2025 16:43:30 -0400 Subject: [PATCH] fix: `uiStatic` release namespace as default When the Metaflow Helm chart is applied in a k8s cluster with a non-default release namespace and `.Values.namespace` is not set or does not match the release namespace value, the `metaflow-ui-static` service will be in a different namespace than its deployment. This means that the service will never have any endpoints associated with it. This commit removes the template syntax to set the namespace as `default` if `.Values.namespace` is not set. There is a larger discrepancy here in that the UI deployments are always in the release namespace, but their services may be in a different namespace. This commit only makes the templates consistent and does not address this issue. --- .../metaflow/charts/metaflow-ui/templates/static_service.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/metaflow/charts/metaflow-ui/templates/static_service.yaml b/charts/metaflow/charts/metaflow-ui/templates/static_service.yaml index 425572e..dd06c61 100644 --- a/charts/metaflow/charts/metaflow-ui/templates/static_service.yaml +++ b/charts/metaflow/charts/metaflow-ui/templates/static_service.yaml @@ -2,7 +2,7 @@ apiVersion: v1 kind: Service metadata: name: "{{ include "metaflow-ui.fullname-static" . }}" - namespace: {{ .Values.namespace | default "default" }} + namespace: {{ .Values.namespace }} labels: {{- include "metaflow-ui.labelsStatic" . | nindent 4 }} spec: