Fix memory leak in variable translation proxies

The members m_variableArgsNames, m_variableArgsGetNames, and m_variableArgsPostNames were allocated using new but stored as references. This caused a memory leak because their destructors were never called.

This change wraps the allocations in std::unique_ptr to ensure proper cleanup while keeping the reference members to maintain compatibility with existing code syntax.

Author: FireBurn

headers/modsecurity/transaction.h

@@ -205,9 +205,12 @@ class TransactionAnchoredVariables {
         m_variableFilesTmpNames(t, "FILES_TMPNAMES"),
         m_variableMultipartPartHeaders(t, "MULTIPART_PART_HEADERS"),
         m_variableOffset(0),
-        m_variableArgsNames("ARGS_NAMES", &m_variableArgs),
-        m_variableArgsGetNames("ARGS_GET_NAMES", &m_variableArgsGet),
-        m_variableArgsPostNames("ARGS_POST_NAMES", &m_variableArgsPost)
+        m_pVariableArgsNames(new AnchoredSetVariableTranslationProxy("ARGS_NAMES", &m_variableArgs)),
+        m_variableArgsNames(*m_pVariableArgsNames),
+        m_pVariableArgsGetNames(new AnchoredSetVariableTranslationProxy("ARGS_GET_NAMES", &m_variableArgsGet)),
+        m_variableArgsGetNames(*m_pVariableArgsGetNames),
+        m_pVariableArgsPostNames(new AnchoredSetVariableTranslationProxy("ARGS_POST_NAMES", &m_variableArgsPost)),
+        m_variableArgsPostNames(*m_pVariableArgsPostNames)
         { }
 
     AnchoredSetVariable m_variableRequestHeadersNames;
@@ -291,9 +294,12 @@ class TransactionAnchoredVariables {
 
     int m_variableOffset;
 
-    AnchoredSetVariableTranslationProxy m_variableArgsNames;
-    AnchoredSetVariableTranslationProxy m_variableArgsGetNames;
-    AnchoredSetVariableTranslationProxy m_variableArgsPostNames;
+    std::unique_ptr<AnchoredSetVariableTranslationProxy> m_pVariableArgsNames;
+    AnchoredSetVariableTranslationProxy &m_variableArgsNames;
+    std::unique_ptr<AnchoredSetVariableTranslationProxy> m_pVariableArgsGetNames;
+    AnchoredSetVariableTranslationProxy &m_variableArgsGetNames;
+    std::unique_ptr<AnchoredSetVariableTranslationProxy> m_pVariableArgsPostNames;
+    AnchoredSetVariableTranslationProxy &m_variableArgsPostNames;
 };
 
 class TransactionSecMarkerManagement {