[DC-81] fix: leak of AccountState (#12254)

Fix leak of `AccountState`

Author: erikjv

src/gui/accountmanager.cpp

@@ -321,12 +321,7 @@ bool AccountManager::accountForLoginExists(const QUrl &url, const QString &davUs
 
 QList<AccountState *> AccountManager::accountsRaw() const
 {
-    QList<AccountState *> out;
-    out.reserve(_accounts.size());
-    for (auto &x : _accounts) {
-        out.append(x);
-    }
-    return out;
+    return _accounts.values();
 }
 
 AccountPtr AccountManager::loadAccountHelper(QSettings &settings)
@@ -447,9 +442,20 @@ AccountPtr AccountManager::createAccount(const QUuid &uuid)
 void AccountManager::shutdown()
 {
     const auto accounts = std::move(_accounts);
-    for (const auto &acc : accounts) {
+    for (AccountState *acc : accounts) {
         Q_EMIT accountRemoved(acc);
+        delete acc;
+    }
+}
+
+const QList<AccountStatePtr> AccountManager::accounts() const
+{
+    QList<AccountStatePtr> ptrs;
+    ptrs.reserve(_accounts.size());
+    for (AccountState *acc : _accounts) {
+        ptrs.append(acc);
     }
+    return ptrs;
 }
 
 bool AccountManager::isAccountIdAvailable(const QString &id) const

src/gui/accountmanager.h

@@ -78,7 +78,7 @@ class OWNCLOUDGUI_EXPORT AccountManager : public QObject
     /**
      * Return a list of all accounts.
      */
-    const QList<AccountStatePtr> accounts() const { return _accounts.values(); }
+    const QList<AccountStatePtr> accounts() const;
 
     /**
      * Return the account state pointer for an account identified by its display name
@@ -144,7 +144,7 @@ public Q_SLOTS:
 
 private:
     AccountManager() {}
-    QMap<QUuid, AccountStatePtr> _accounts;
+    QMap<QUuid, AccountState *> _accounts;
     /// Account ids from settings that weren't read
     QSet<QString> _additionalBlockedAccountIds;
 };