fix(linter/no-unsafe-declaration-merging): always mark first span as primary (#13830)

This is technically a breaking change, but more closely aligns our implementation with typescript-eslint, and makes placement of the disable directive more predictable.

Previously, it was unclear where the disable directive should go (on the clase or on the interface), this PR enforces that the directive must go on the `class`.

Author: camc314

apps/oxlint/fixtures/disable_directive_issue_13311/.oxlintrc.json

@@ -0,0 +1,10 @@
+{
+  "plugins": ["eslint", "typescript", "react"],
+  "categories": {
+    "correctness": "off"
+  },
+  "rules": {
+    "react/exhaustive-deps": "warn",
+    "typescript/no-unsafe-declaration-merging": "error"
+  }
+}

apps/oxlint/fixtures/exhaustive_deps_disable_directive_issue_13311/test.jsx renamed to apps/oxlint/fixtures/disable_directive_issue_13311/test.jsx

@@ -10,4 +10,5 @@ function Component() {
   }, []);
 
   return null;
-}
+}
+

apps/oxlint/fixtures/disable_directive_issue_13311/test2.d.ts

@@ -0,0 +1,9 @@
+// oxlint-disable-next-line typescript/no-unsafe-declaration-merging
+export interface Component {}
+
+export abstract class Component {}
+
+// oxlint-disable-next-line typescript/no-unsafe-declaration-merging
+export abstract class Component2 {}
+
+export interface Component2 {}

apps/oxlint/fixtures/exhaustive_deps_disable_directive_issue_13311/.oxlintrc.json

@@ -1252,13 +1252,13 @@ mod test {
     }
 
     #[test]
-    fn test_exhaustive_deps_disable_directive_issue_13311() {
+    fn test_disable_directive_issue_13311() {
         // Test that exhaustive-deps diagnostics are reported at the dependency array
         // so that disable directives work correctly
         // Issue: https://github.com/oxc-project/oxc/issues/13311
-        let args = &["test.jsx"];
+        let args = &["test.jsx", "test2.d.ts"];
         Tester::new()
-            .with_cwd("fixtures/exhaustive_deps_disable_directive_issue_13311".into())
+            .with_cwd("fixtures/disable_directive_issue_13311".into())
             .test_and_snapshot(args);
     }
 

apps/oxlint/src/lint.rs

@@ -0,0 +1,12 @@
+---
+source: apps/oxlint/src/tester.rs
+---
+########## 
+arguments: test.jsx test2.d.ts
+working directory: fixtures/disable_directive_issue_13311
+----------
+Found 0 warnings and 0 errors.
+Finished in <variable>ms on 2 files using 1 threads.
+----------
+CLI result: LintSucceeded
+----------

apps/oxlint/src/snapshots/fixtures__disable_directive_issue_13311_test.jsx [email protected]

@@ -13,7 +13,7 @@ use crate::{
 fn no_unsafe_declaration_merging_diagnostic(span: Span, span1: Span) -> OxcDiagnostic {
     OxcDiagnostic::warn("Unsafe declaration merging between classes and interfaces.")
         .with_help("The TypeScript compiler doesn't check whether properties are initialized, which can lead to TypeScript not detecting code that will cause runtime errors.")
-        .with_labels([span, span1])
+        .with_labels(if span < span1 { [span, span1]} else { [span1, span] })
 }
 
 #[derive(Debug, Default, Clone)]