fix(linter): parse ignorePatterns with gitignore syntax (#13221)

closes #13204

Why I need now a `GitignoreBuilder` instead of `OverrideBuilder` like before #12210.
Because `Gitignore::matched_path_or_any_parents` only allows paths inside his root, I needed to "trick" a bit.
Or else the test with `--config another/directory/config.json` would fail.

Now, the base `ignorePatterns` will always be at the current working directory.

Author: Sysix

apps/oxlint/fixtures/ignore_pattern_non_glob_syntax/.oxlintrc.json

@@ -0,0 +1,5 @@
+{
+  "ignorePatterns": [
+    "ignored_dir"
+  ]
+}

apps/oxlint/fixtures/ignore_pattern_non_glob_syntax/ignored_dir/index.ts

@@ -0,0 +1 @@
+debugger;

apps/oxlint/fixtures/ignore_pattern_non_glob_syntax/with_nested/.oxlintrc.json

@@ -0,0 +1,5 @@
+{
+  "ignorePatterns": [
+    "ignored_dir"
+  ]
+}

apps/oxlint/fixtures/ignore_pattern_non_glob_syntax/with_nested/ignored_dir/index.ts

@@ -0,0 +1 @@
+debugger;

apps/oxlint/src/lint.rs

@@ -205,7 +205,8 @@ impl LintRunner {
         } else {
             None
         };
-        let config_builder = match ConfigStoreBuilder::from_oxlintrc(
+        let config_builder = match ConfigStoreBuilder::from_base_oxlintrc(
+            &self.cwd,
             false,
             oxlintrc,
             external_linter,
@@ -667,6 +668,16 @@ mod test {
             .test_and_snapshot_multiple(&[args1, args2]);
     }
 
+    #[test]
+    // https://github.com/oxc-project/oxc/issues/13204
+    fn ignore_pattern_non_glob_syntax() {
+        let args1 = &[];
+        let args2 = &["."];
+        Tester::new()
+            .with_cwd("fixtures/ignore_pattern_non_glob_syntax".into())
+            .test_and_snapshot_multiple(&[args1, args2]);
+    }
+
     #[test]
     fn filter_allow_all() {
         let args = &["-A", "all", "fixtures/linter"];

apps/oxlint/src/snapshots/fixtures__ignore_pattern_non_glob_syntax_ [email protected]

@@ -0,0 +1,22 @@
+---
+source: apps/oxlint/src/tester.rs
+---
+########## 
+arguments: 
+working directory: fixtures/ignore_pattern_non_glob_syntax
+----------
+Found 0 warnings and 0 errors.
+Finished in <variable>ms on 0 files using 1 threads.
+----------
+CLI result: LintSucceeded
+----------
+
+########## 
+arguments: .
+working directory: fixtures/ignore_pattern_non_glob_syntax
+----------
+Found 0 warnings and 0 errors.
+Finished in <variable>ms on 0 files using 1 threads.
+----------
+CLI result: LintSucceeded
+----------

crates/oxc_language_server/src/linter/server_linter.rs

@@ -49,7 +49,8 @@ impl ServerLinter {
             Oxlintrc::default()
         };
 
-        let config_builder = ConfigStoreBuilder::from_oxlintrc(
+        let config_builder = ConfigStoreBuilder::from_base_oxlintrc(
+            &root_path,
             false,
             oxlintrc,
             None,

crates/oxc_linter/src/config/config_builder.rs

@@ -100,6 +100,49 @@ impl ConfigStoreBuilder {
         oxlintrc: Oxlintrc,
         external_linter: Option<&ExternalLinter>,
         external_plugin_store: &mut ExternalPluginStore,
+    ) -> Result<Self, ConfigBuilderError> {
+        let parent_path =
+            oxlintrc.path.parent().map_or_else(|| PathBuf::from("."), std::path::Path::to_path_buf);
+
+        Self::from_oxlintrc_with_ignore_root(
+            start_empty,
+            oxlintrc,
+            external_linter,
+            external_plugin_store,
+            parent_path.as_path(),
+        )
+    }
+
+    /// Similar to the [`ConfigStoreBuilder::from_oxlintrc`] method, but
+    /// applies the config on top of a default [`Oxlintrc`].
+    /// The ignore root of this file, should be the current working directory.
+    /// Even if the file is not located at the current working directory.
+    ///
+    /// # Errors
+    ///
+    /// Returns [`ConfigBuilderError::InvalidConfigFile`] if a referenced config file is not valid.
+    pub fn from_base_oxlintrc(
+        cwd: &Path,
+        start_empty: bool,
+        oxlintrc: Oxlintrc,
+        external_linter: Option<&ExternalLinter>,
+        external_plugin_store: &mut ExternalPluginStore,
+    ) -> Result<Self, ConfigBuilderError> {
+        Self::from_oxlintrc_with_ignore_root(
+            start_empty,
+            oxlintrc,
+            external_linter,
+            external_plugin_store,
+            cwd,
+        )
+    }
+
+    fn from_oxlintrc_with_ignore_root(
+        start_empty: bool,
+        oxlintrc: Oxlintrc,
+        external_linter: Option<&ExternalLinter>,
+        external_plugin_store: &mut ExternalPluginStore,
+        ignore_root: &Path,
     ) -> Result<Self, ConfigBuilderError> {
         // TODO: this can be cached to avoid re-computing the same oxlintrc
         fn resolve_oxlintrc_config(
@@ -167,7 +210,6 @@ impl ConfigStoreBuilder {
 
             let resolver = Resolver::default();
 
-            #[expect(clippy::missing_panics_doc, reason = "oxlintrc.path is always a file path")]
             let oxlintrc_dir = oxlintrc.path.parent().unwrap();
 
             for plugin_specifier in &external_plugins {
@@ -201,7 +243,7 @@ impl ConfigStoreBuilder {
             globals: oxlintrc.globals,
             ignore_patterns: LintConfig::resolve_oxlintrc_ignore_patterns(
                 &oxlintrc.ignore_patterns,
-                &oxlintrc.path,
+                ignore_root,
             ),
             path: Some(oxlintrc.path),
         };

crates/oxc_linter/src/config/config_store.rs

@@ -330,9 +330,9 @@ impl ConfigStore {
     }
 
     pub fn should_ignore(&self, path: &Path) -> bool {
-        self.get_related_config(path)
-            .ignore_patterns()
-            .is_some_and(|ignore_patterns| ignore_patterns.matched(path, false).is_ignore())
+        self.get_related_config(path).ignore_patterns().is_some_and(|ignore_patterns| {
+            ignore_patterns.matched_path_or_any_parents(path, false).is_ignore()
+        })
     }
 
     // NOTE: This function is not crate visible because it is used in `oxlint` as well to resolve configs

crates/oxc_linter/src/config/mod.rs

@@ -14,14 +14,14 @@ pub use config_builder::{ConfigBuilderError, ConfigStoreBuilder};
 pub use config_store::{Config, ConfigStore, ResolvedLinterState};
 pub use env::OxlintEnv;
 pub use globals::{GlobalValue, OxlintGlobals};
-use ignore::overrides::OverrideBuilder;
+use ignore::gitignore::{Gitignore, GitignoreBuilder};
 pub use overrides::OxlintOverrides;
 pub use oxlintrc::Oxlintrc;
 pub use plugins::{BuiltinLintPlugins, LintPlugins};
 pub use rules::{ESLintRule, OxlintRules};
 pub use settings::{OxlintSettings, jsdoc::JSDocPluginSettings};
 
-pub type ResolvedIgnorePatterns = ignore::overrides::Override;
+pub type ResolvedIgnorePatterns = Gitignore;
 
 #[derive(Debug, Default, Clone)]
 pub struct LintConfig {
@@ -53,23 +53,19 @@ impl From<Oxlintrc> for LintConfig {
 impl LintConfig {
     pub(crate) fn resolve_oxlintrc_ignore_patterns(
         ignore_patterns: &[String],
-        config_path: &Path,
+        ignore_root: &Path,
     ) -> Option<ResolvedIgnorePatterns> {
         if ignore_patterns.is_empty() {
             return None;
         }
-        // expect that every oxlint config file with "ignorePatterns" provides its config path with parent.
-        // for the default config the path is empty, but there should be no ignore patterns
-        let oxlint_wd = config_path.parent()?.to_path_buf();
 
-        let mut builder = OverrideBuilder::new(&oxlint_wd);
+        let mut gitignore_builder = GitignoreBuilder::new(ignore_root);
 
         for pattern in ignore_patterns {
-            let pattern = format!("!{pattern}");
-            builder.add(&pattern).unwrap();
+            gitignore_builder.add_line(None, pattern).unwrap();
         }
 
-        builder.build().ok()
+        gitignore_builder.build().ok()
     }
 }