Skip to content

Update MauiOxyTouchEventArgs.cs #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Conversation

SimGoodwinHWM
Copy link
Contributor

Change access modifier to match constructor

Allows access to public property when instance of this class is returned

Change access modifier to match constructor
@VisualMelon
Copy link

PointerCount appears to exist to facilitate some internal Maui specific logic; however, I'm unfamiliar with Maui, and it looks like the Oxyplot-Maui provision may have some outstanding issues with touch support, so I wouldn't be surprised if this was liable to change.

What's your need for accessing the PointerCount?

@SimGoodwinHWM
Copy link
Contributor Author

SimGoodwinHWM commented Mar 10, 2025

I agree it will probably change, though the OxyPlot PlotController methods for handling touch events also use OxyTouchEventArgs so this may still apply with further changes, if touch controlls continue to be supported.

I was hoping to use it with the (admittedly depreciated) PlotModel.TouchCompleted event to assist in determining user intent, specifically whether they are trying to zoom in or move an element on a fully zoomed out graph.

Copy link
Member

@janusw janusw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a good reason why we shouldn't allow access to PointerCount, so: Ok with me! 👍

@janusw janusw merged commit 2d4738d into oxyplot:develop Mar 31, 2025
3 checks passed
@janusw
Copy link
Member

janusw commented Mar 31, 2025

Merged. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants