Skip to content

Commit 14f79a0

Browse files
committed
1 parent c7a085e commit 14f79a0

File tree

4 files changed

+85
-12
lines changed

4 files changed

+85
-12
lines changed

tests/series/arithmetic/complex/test_add.py

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,28 @@ def test_add_numpy_array() -> None:
5959
check(assert_type(left + f, "pd.Series[complex]"), pd.Series, np.complex128)
6060
check(assert_type(left + c, "pd.Series[complex]"), pd.Series, np.complex128)
6161

62-
# check(assert_type(i + l, "pd.Series[complex]"), pd.Series, np.complex128)
63-
# check(assert_type(f + l, "pd.Series[complex]"), pd.Series, np.complex128)
64-
# check(assert_type(c + l, "pd.Series[complex]"), pd.Series, np.complex128)
62+
# numpy typing gives ndarray instead of `pd.Series[...]` in reality, which we cannot fix
63+
check(
64+
assert_type( # type: ignore[assert-type]
65+
i + left, "pd.Series[complex]" # pyright: ignore[reportAssertTypeFailure]
66+
),
67+
pd.Series,
68+
np.complex128,
69+
)
70+
check(
71+
assert_type( # type: ignore[assert-type]
72+
f + left, "pd.Series[complex]" # pyright: ignore[reportAssertTypeFailure]
73+
),
74+
pd.Series,
75+
np.complex128,
76+
)
77+
check(
78+
assert_type( # type: ignore[assert-type]
79+
c + left, "pd.Series[complex]" # pyright: ignore[reportAssertTypeFailure]
80+
),
81+
pd.Series,
82+
np.complex128,
83+
)
6584

6685
check(assert_type(left.add(i), "pd.Series[complex]"), pd.Series, np.complex128)
6786
check(assert_type(left.add(f), "pd.Series[complex]"), pd.Series, np.complex128)

tests/series/arithmetic/float/test_add.py

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,28 @@ def test_add_numpy_array() -> None:
5959
check(assert_type(left + f, "pd.Series[float]"), pd.Series, np.float64)
6060
check(assert_type(left + c, "pd.Series[complex]"), pd.Series, np.complex128)
6161

62-
# check(assert_type(i + l, "pd.Series[float]"), pd.Series, np.float64)
63-
# check(assert_type(f + l, "pd.Series[float]"), pd.Series, np.float64)
64-
# check(assert_type(c + l, "pd.Series[complex]"), pd.Series, np.complex128)
62+
# numpy typing gives ndarray instead of `pd.Series[...]` in reality, which we cannot fix
63+
check(
64+
assert_type( # type: ignore[assert-type]
65+
i + left, "pd.Series[float]" # pyright: ignore[reportAssertTypeFailure]
66+
),
67+
pd.Series,
68+
np.float64,
69+
)
70+
check(
71+
assert_type( # type: ignore[assert-type]
72+
f + left, "pd.Series[float]" # pyright: ignore[reportAssertTypeFailure]
73+
),
74+
pd.Series,
75+
np.float64,
76+
)
77+
check(
78+
assert_type( # type: ignore[assert-type]
79+
c + left, "pd.Series[complex]" # pyright: ignore[reportAssertTypeFailure]
80+
),
81+
pd.Series,
82+
np.complex128,
83+
)
6584

6685
check(assert_type(left.add(i), "pd.Series[float]"), pd.Series, np.float64)
6786
check(assert_type(left.add(f), "pd.Series[float]"), pd.Series, np.float64)

tests/series/arithmetic/int/test_add.py

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,28 @@ def test_add_numpy_array() -> None:
5959
check(assert_type(left + f, "pd.Series[float]"), pd.Series, np.float64)
6060
check(assert_type(left + c, "pd.Series[complex]"), pd.Series, np.complex128)
6161

62-
# check(assert_type(i + l, "pd.Series[int]"), pd.Series, np.int64)
63-
# check(assert_type(f + l, "pd.Series[float]"), pd.Series, np.float64)
64-
# check(assert_type(c + l, "pd.Series[complex]"), pd.Series, np.complex128)
62+
# numpy typing gives ndarray instead of `pd.Series[...]` in reality, which we cannot fix
63+
check(
64+
assert_type( # type: ignore[assert-type]
65+
i + left, "pd.Series[int]" # pyright: ignore[reportAssertTypeFailure]
66+
),
67+
pd.Series,
68+
np.int64,
69+
)
70+
check(
71+
assert_type( # type: ignore[assert-type]
72+
f + left, "pd.Series[float]" # pyright: ignore[reportAssertTypeFailure]
73+
),
74+
pd.Series,
75+
np.float64,
76+
)
77+
check(
78+
assert_type( # type: ignore[assert-type]
79+
c + left, "pd.Series[complex]" # pyright: ignore[reportAssertTypeFailure]
80+
),
81+
pd.Series,
82+
np.complex128,
83+
)
6584

6685
check(assert_type(left.add(i), "pd.Series[int]"), pd.Series, np.int64)
6786
check(assert_type(left.add(f), "pd.Series[float]"), pd.Series, np.float64)

tests/series/arithmetic/test_add.py

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,25 @@ def test_add_numpy_array() -> None:
5959
check(assert_type(left + f, pd.Series), pd.Series)
6060
check(assert_type(left + c, pd.Series), pd.Series)
6161

62-
# check(assert_type(i + l, pd.Series), pd.Series)
63-
# check(assert_type(f + l, pd.Series), pd.Series)
64-
# check(assert_type(c + l, pd.Series), pd.Series)
62+
# numpy typing gives ndarray instead of `pd.Series[...]` in reality, which we cannot fix
63+
check(
64+
assert_type( # type: ignore[assert-type]
65+
i + left, pd.Series # pyright: ignore[reportAssertTypeFailure]
66+
),
67+
pd.Series,
68+
)
69+
check(
70+
assert_type( # type: ignore[assert-type]
71+
f + left, pd.Series # pyright: ignore[reportAssertTypeFailure]
72+
),
73+
pd.Series,
74+
)
75+
check(
76+
assert_type( # type: ignore[assert-type]
77+
c + left, pd.Series # pyright: ignore[reportAssertTypeFailure]
78+
),
79+
pd.Series,
80+
)
6581

6682
check(assert_type(left.add(i), pd.Series), pd.Series)
6783
check(assert_type(left.add(f), pd.Series), pd.Series)

0 commit comments

Comments
 (0)