type IndexOpsMixin #1357
type IndexOpsMixin #1357
Conversation
MarcoGorelli
force-pushed
the
indexopsmixin
branch
from
8a1df28 to
396ab9c
Compare
MarcoGorelli
force-pushed
the
indexopsmixin
branch
from
396ab9c to
43b25af
Compare
| SupportsDType, | ||
| np_1darray, | ||
| ) | ||
| from pandas.util._decorators import cache_readonly | ||
|
|
||
| _ListLike: TypeAlias = ArrayLike | dict[str, np.ndarray] | SequenceNotStr[S1] |
There was a problem hiding this comment.
not sure why this gets redefined in multiple files, but i've kept to the pattern
ok, or better to redefine in _typing?
There was a problem hiding this comment.
If you do want to use it here, then I think moving the definition to typing.pyi makes sense, but exercise care on the naming, because there is a ListLike in _typing that is used elsewhere and I'm not sure whether they should be the same or not. Maybe the name _ListLike is misleading.
Might be better to do the copying like you've done here, OR have series.pyi import _ListLike from core/base.pyi
There was a problem hiding this comment.
Might be better to do the copying like you've done here
sure, keeping like this for now then, thanks
| SupportsDType, | ||
| np_1darray, | ||
| ) | ||
| from pandas.util._decorators import cache_readonly | ||
|
|
||
| _ListLike: TypeAlias = ArrayLike | dict[str, np.ndarray] | SequenceNotStr[S1] |
There was a problem hiding this comment.
If you do want to use it here, then I think moving the definition to typing.pyi makes sense, but exercise care on the naming, because there is a ListLike in _typing that is used elsewhere and I'm not sure whether they should be the same or not. Maybe the name _ListLike is misleading.
Might be better to do the copying like you've done here, OR have series.pyi import _ListLike from core/base.pyi
|
sure, happy for you to take a look, thanks! |
closes #1356
assert_type()to assert the type of any return value