Skip to content

Commit 3a4473d

Browse files
committed
fixes based on PR review
1 parent 69c0f76 commit 3a4473d

File tree

4 files changed

+12
-9
lines changed

4 files changed

+12
-9
lines changed

pandas/core/algorithms.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1314,7 +1314,7 @@ def searchsorted(
13141314
_diff_special = {"float64", "float32", "int64", "int32", "int16", "int8"}
13151315

13161316

1317-
def diff(arr, n: int | float | np.integer, axis: AxisInt = 0):
1317+
def diff(arr, n: int | float | np.integer | np.floating, axis: AxisInt = 0):
13181318
"""
13191319
difference of n between self,
13201320
analogous to s-s.shift(n)

pandas/core/arrays/masked.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -713,7 +713,7 @@ def _hasna(self) -> bool:
713713
# make this faster by having an optional mask, but not have to change
714714
# source code using it..
715715

716-
return cast(bool, self._mask.any())
716+
return bool(self._mask.any())
717717

718718
def _propagate_mask(
719719
self, mask: npt.NDArray[np.bool_] | None, other

pandas/io/parsers/readers.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
Self,
2323
TypedDict,
2424
Unpack,
25+
cast,
2526
overload,
2627
)
2728
import warnings
@@ -1818,7 +1819,7 @@ def _refine_defaults_read(
18181819
return kwds
18191820

18201821

1821-
def _extract_dialect(kwds: dict[str, Any]) -> csv.Dialect | None:
1822+
def _extract_dialect(kwds: dict[str, str]) -> csv.Dialect | None:
18221823
"""
18231824
Extract concrete csv dialect instance.
18241825
@@ -1831,11 +1832,14 @@ def _extract_dialect(kwds: dict[str, Any]) -> csv.Dialect | None:
18311832

18321833
dialect = kwds["dialect"]
18331834
if dialect in csv.list_dialects():
1834-
dialect = csv.get_dialect(dialect)
1835+
# get_dialect is typed to return a `_csv.Dialect` for some reason in typeshed
1836+
tdialect = cast(csv.Dialect, csv.get_dialect(dialect))
18351837

1836-
_validate_dialect(dialect)
1838+
_validate_dialect(tdialect)
1839+
else:
1840+
tdialect = None
18371841

1838-
return dialect # pyright: ignore[reportReturnType]
1842+
return tdialect
18391843

18401844

18411845
MANDATORY_DIALECT_ATTRS = (
@@ -1848,7 +1852,7 @@ def _extract_dialect(kwds: dict[str, Any]) -> csv.Dialect | None:
18481852
)
18491853

18501854

1851-
def _validate_dialect(dialect: csv.Dialect | Any) -> None:
1855+
def _validate_dialect(dialect: csv.Dialect | str) -> None:
18521856
"""
18531857
Validate csv dialect instance.
18541858

pandas/io/pytables.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@
128128
AxisInt,
129129
DtypeArg,
130130
FilePath,
131-
Shape,
132131
npt,
133132
)
134133

@@ -3384,7 +3383,7 @@ class BlockManagerFixed(GenericFixed):
33843383
nblocks: int
33853384

33863385
@property
3387-
def shape(self) -> Shape | list[int] | None:
3386+
def shape(self) -> list[int] | None:
33883387
try:
33893388
ndim = self.ndim
33903389

0 commit comments

Comments
 (0)