Skip to content

Commit a8644f9

Browse files
try with Self everywhere, ignore override in datetimelike
1 parent 29ba5fe commit a8644f9

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

pandas/core/arrays/_mixins.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ def _validate_scalar(self, value):
114114
# ------------------------------------------------------------------------
115115

116116
@overload
117-
def view(self) -> ExtensionArray: ...
117+
def view(self) -> Self: ...
118118

119119
@overload
120120
def view(self, dtype: Dtype | None = ...) -> ArrayLike: ...

pandas/core/arrays/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1805,7 +1805,7 @@ def copy(self) -> Self:
18051805
raise AbstractMethodError(self)
18061806

18071807
@overload
1808-
def view(self) -> ExtensionArray: ...
1808+
def view(self) -> Self: ...
18091809

18101810
@overload
18111811
def view(self, dtype: Dtype | None = ...) -> ArrayLike: ...

pandas/core/arrays/datetimelike.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -508,8 +508,8 @@ def astype(self, dtype, copy: bool = True):
508508
else:
509509
return np.asarray(self, dtype=dtype)
510510

511-
@overload
512-
def view(self) -> ExtensionArray: ...
511+
@overload # type: ignore[override]
512+
def view(self) -> Self: ...
513513

514514
@overload
515515
def view(self, dtype: Literal["M8[ns]"]) -> DatetimeArray: ...

pandas/core/arrays/string_.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -546,7 +546,7 @@ def _str_map_nan_semantics(
546546
else:
547547
return self._str_map_str_or_object(dtype, na_value, arr, f, mask)
548548

549-
def view(self, dtype: Dtype | None = None) -> ExtensionArray:
549+
def view(self, dtype: Dtype | None = None) -> Self:
550550
if dtype is not None:
551551
raise TypeError("Cannot change data-type for string array.")
552552
return super().view()

0 commit comments

Comments
 (0)