Skip to content

Conversation

AnandMukherjee2004
Copy link

@AnandMukherjee2004
Copy link
Author

Hi maintainers,

The CI is failing with a mypy error in pandas/io/excel/_xlsxwriter.py:
error: Argument 1 to "Workbook" has incompatible type "IO[bytes]"; expected "str | None" [arg-type]

My PR only changes documentation files and does not touch any Excel or type-related code. Could you please confirm if this mypy error is present on the main branch, and advise if I need to take any action? Thanks!

@Alvaro-Kothe
Copy link
Contributor

@AnandMukherjee2004 Merge from main, this is fixed on upstream.

@AnandMukherjee2004 AnandMukherjee2004 force-pushed the doc/clarify-parentheses-vs-brackets-62314 branch from 0a20c3b to de05cf1 Compare September 16, 2025 03:51
@AnandMukherjee2004
Copy link
Author

All checks are passing. This PR is ready for review. Thanks!

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead, could you just add a text-only paragraph in this section from the guide in the original issue? https://python-public-policy.afeld.me/en/columbia/brackets.html

@AnandMukherjee2004
Copy link
Author

Instead, could you just add a text-only paragraph in this section from the guide in the original issue? https://python-public-policy.afeld.me/en/columbia/brackets.html

like should I make it more concise, and add just text para from the guide?

@AnandMukherjee2004 AnandMukherjee2004 force-pushed the doc/clarify-parentheses-vs-brackets-62314 branch from de05cf1 to 41272b9 Compare September 16, 2025 16:45
@mroeschke
Copy link
Member

add just text para from the guide

Sorry I should have been more specific. Just adding a paragraph in this section with a link to https://python-public-policy.afeld.me/en/columbia/brackets.html

@AnandMukherjee2004
Copy link
Author

add just text para from the guide

Sorry I should have been more specific. Just adding a paragraph in this section with a link to https://python-public-policy.afeld.me/en/columbia/brackets.html

All requested changes have been made. All checks are now passing, and the section contains the requested plain paragraph with a reference link. This PR is ready for further review.
Thanks!

@afeld
Copy link
Member

afeld commented Sep 17, 2025

/preview

Copy link
Contributor

Website preview of this PR available at: https://pandas.pydata.org/preview/pandas-dev/pandas/62347/

Copy link
Member

@afeld afeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank you!

@AnandMukherjee2004
Copy link
Author

Nice work, thank you!

The documentation preview looks good, but the PR is still marked as blocked from merging.
Is there anything else you need from me to unblock it?
Thanks!

@afeld
Copy link
Member

afeld commented Sep 17, 2025

I think @mroeschke will need to approve and merge.

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks but I don't think this change requires custom HTML or a new page.

I would suggest adding a line in doc/source/getting_started/intro_tutorials/03_subset_data.rst where square brackets are first referenced that says For more explanation, see `Brackets in Python and pandas <https://python-public-policy.afeld.me/en/columbia/brackets.html>`__.

@AnandMukherjee2004
Copy link
Author

AnandMukherjee2004 commented Sep 17, 2025

Thanks but I don't think this change requires custom HTML or a new page.

I would suggest adding a line in doc/source/getting_started/intro_tutorials/03_subset_data.rst where square brackets are first referenced that says For more explanation, see `Brackets in Python and pandas <https://python-public-policy.afeld.me/en/columbia/brackets.html>`__.

working on it.

@mroeschke
Copy link
Member

so should i remove this page and add the link in subset_data.rst page only?

Yes, please

@AnandMukherjee2004
Copy link
Author

so should i remove this page and add the link in subset_data.rst page only?

Yes, please

done!! Please check and proceed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Clarify parentheses vs. brackets
5 participants