-
-
Notifications
You must be signed in to change notification settings - Fork 19k
DOC: Clarify parentheses vs. brackets usage (GH#62314) #62347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
DOC: Clarify parentheses vs. brackets usage (GH#62314) #62347
Conversation
Hi maintainers, The CI is failing with a mypy error in pandas/io/excel/_xlsxwriter.py: My PR only changes documentation files and does not touch any Excel or type-related code. Could you please confirm if this mypy error is present on the main branch, and advise if I need to take any action? Thanks! |
@AnandMukherjee2004 Merge from main, this is fixed on upstream. |
0a20c3b
to
de05cf1
Compare
All checks are passing. This PR is ready for review. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead, could you just add a text-only paragraph in this section from the guide in the original issue? https://python-public-policy.afeld.me/en/columbia/brackets.html
like should I make it more concise, and add just text para from the guide? |
de05cf1
to
41272b9
Compare
Sorry I should have been more specific. Just adding a paragraph in this section with a link to https://python-public-policy.afeld.me/en/columbia/brackets.html |
All requested changes have been made. All checks are now passing, and the section contains the requested plain paragraph with a reference link. This PR is ready for further review. |
/preview |
Website preview of this PR available at: https://pandas.pydata.org/preview/pandas-dev/pandas/62347/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thank you!
The documentation preview looks good, but the PR is still marked as blocked from merging. |
I think @mroeschke will need to approve and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks but I don't think this change requires custom HTML or a new page.
I would suggest adding a line in doc/source/getting_started/intro_tutorials/03_subset_data.rst
where square brackets are first referenced that says For more explanation, see `Brackets in Python and pandas <https://python-public-policy.afeld.me/en/columbia/brackets.html>`__.
working on it. |
Yes, please |
…ithub.com/AnandMukherjee2004/pandas into doc/clarify-parentheses-vs-brackets-62314
done!! Please check and proceed! |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature (Will add if requested)