-
Notifications
You must be signed in to change notification settings - Fork 2k
Closed
Labels
A-rpcRelated to the RPC implementationRelated to the RPC implementationA-sdkRelated to reth's use as a libraryRelated to reth's use as a libraryC-enhancementNew feature or requestNew feature or requestD-good-first-issueNice and easy! A great choice to get startedNice and easy! A great choice to get started
Description
Describe the feature
we have:
reth/crates/rpc/rpc-builder/src/lib.rs
Lines 1957 to 1961 in bab9dee
| /// Adds or replaces given [`Methods`] in all configured network modules. | |
| pub fn add_or_replace_configured( | |
| &mut self, | |
| other: impl Into<Methods>, | |
| ) -> Result<(), RegisterMethodError> { |
but for merge we also have:
reth/crates/rpc/rpc-builder/src/lib.rs
Lines 1644 to 1652 in bab9dee
| /// Merge the given [`Methods`] in all configured transport modules if the given | |
| /// [`RethRpcModule`] is configured for the transport. | |
| /// | |
| /// Fails if any of the methods in other is present already. | |
| pub fn merge_if_module_configured( | |
| &mut self, | |
| module: RethRpcModule, | |
| other: impl Into<Methods>, | |
| ) -> Result<(), RegisterMethodError> { |
we want the same for replace
TODO
- replicate these fns for add_or_replace_iif_module_configured(:
reth/crates/rpc/rpc-builder/src/lib.rs
Lines 1957 to 1961 in bab9dee
/// Adds or replaces given [`Methods`] in all configured network modules. pub fn add_or_replace_configured( &mut self, other: impl Into<Methods>, ) -> Result<(), RegisterMethodError> {
assigning @Peponks9
Additional context
No response
Peponks9
Metadata
Metadata
Assignees
Labels
A-rpcRelated to the RPC implementationRelated to the RPC implementationA-sdkRelated to reth's use as a libraryRelated to reth's use as a libraryC-enhancementNew feature or requestNew feature or requestD-good-first-issueNice and easy! A great choice to get startedNice and easy! A great choice to get started
Type
Projects
Status
Done