feat: update config paths on windows, fix task scheduler job not working

Author: thedogecraft

docs/.vitepress/config.js

@@ -7,6 +7,7 @@ const currentYear = currentDate.getFullYear();
 export default defineConfig({
   title: "Updatectl",
   description: "A CLI tool for automating project updates",
+  cleanUrls: true,
   base: "/",
   head: [
     ["link", { rel: "icon", href: "/icon.ico" }],

install.bat

@@ -1,28 +1,57 @@
 @echo off
-REM updatectl Windows Installer
+REM updatectl User Installer
 
 echo Installing updatectl...
 
+REM Combine user and system PATH for this session
+for /f "tokens=2*" %%A in ('reg query "HKCU\Environment" /v Path 2^>nul') do set "USER_PATH=%%B"
+for /f "tokens=2*" %%A in ('reg query "HKLM\SYSTEM\CurrentControlSet\Control\Session Manager\Environment" /v Path 2^>nul') do set "SYS_PATH=%%B"
+set "PATH=%USER_PATH%;%SYS_PATH%"
+
 REM Check if Go is installed
 go version >nul 2>&1
 if %errorlevel% neq 0 (
-    echo Error: Go is not installed. Please install Go first.
+    echo Error: Go is not installed or not in PATH.
+    echo Please install Go or restart your terminal after installing it.
     pause
     exit /b 1
 )
 
 REM Build the binary
 echo Building updatectl...
 go build -o updatectl.exe main.go
+if %errorlevel% neq 0 (
+    echo Build failed.
+    pause
+    exit /b 1
+)
 
-REM Create install directory
-if not exist "C:\Program Files\updatectl" mkdir "C:\Program Files\updatectl"
+REM Install location (user home)
+set "INSTALL_DIR=%USERPROFILE%\updatectl"
+if not exist "%INSTALL_DIR%" mkdir "%INSTALL_DIR%"
 
 REM Copy binary
-copy updatectl.exe "C:\Program Files\updatectl\"
+copy /Y updatectl.exe "%INSTALL_DIR%\" >nul
+
+REM Add to user PATH if not already there
+setlocal enabledelayedexpansion
+for /f "tokens=2*" %%A in ('reg query "HKCU\Environment" /v Path 2^>nul') do (
+    set "CUR_PATH=%%B"
+)
+
+echo !CUR_PATH! | find /I "%INSTALL_DIR%" >nul
+if %errorlevel% neq 0 (
+    echo Adding "%INSTALL_DIR%" to your user PATH...
+    setx PATH "!CUR_PATH!;%INSTALL_DIR%" >nul
+) else (
+    echo Path already includes "%INSTALL_DIR%"
+)
 
-echo updatectl installed successfully to C:\Program Files\updatectl\
-echo Make sure C:\Program Files\updatectl is in your PATH.
-echo Run 'updatectl init' to set up the daemon.
+endlocal
 
-pause
+echo.
+echo updatectl installed successfully to "%INSTALL_DIR%"
+echo.
+echo You can now run "updatectl" from any new command prompt.
+echo Run "updatectl init" to set up the daemon.
+pause

main.go

@@ -62,7 +62,7 @@ var initCmd = &cobra.Command{
 		var configDir, configPath string
 
 		if runtime.GOOS == "windows" {
-			configDir = filepath.Join(os.Getenv("ProgramData"), "updatectl")
+			configDir = filepath.Join(os.Getenv("USERPROFILE"), "updatectl")
 		} else {
 			configDir = "/etc/updatectl"
 		}
@@ -86,9 +86,45 @@ projects:
 		}
 
 		if runtime.GOOS == "windows" {
-			taskCmd := `schtasks /Create /TN "updatectl" /TR "updatectl watch" /SC ONSTART /RL HIGHEST /F`
-			exec.Command("cmd", "/C", taskCmd).Run()
+			taskName := "updatectl"
+			configDir := filepath.Join(os.Getenv("USERPROFILE"), "updatectl")
+
+			batScript := fmt.Sprintf(`@echo off
+start "" /b "%s" watch
+`, filepath.Join(configDir, "updatectl.exe"))
+			batScriptPath := filepath.Join(configDir, "run_updatectl.bat")
+
+			err := os.WriteFile(batScriptPath, []byte(batScript), 0644)
+			if err != nil {
+				fmt.Println("Failed to write batch wrapper script:", err)
+				return
+			}
+
+			taskRun := batScriptPath
+
+			cmd := exec.Command(
+				"schtasks",
+				"/Create",
+				"/TN", taskName,
+				"/TR", taskRun,
+				"/SC", "ONSTART",
+				"/RL", "HIGHEST",
+				"/F",
+			)
+			output, err := cmd.CombinedOutput()
+			if err != nil {
+				fmt.Printf("Failed to create scheduled task: %v\nOutput: %s\n", err, output)
+				return
+			}
 			fmt.Println("Created Windows Task Scheduler job for updatectl.")
+
+			runCmd := exec.Command("schtasks", "/Run", "/TN", taskName)
+			runOutput, runErr := runCmd.CombinedOutput()
+			if runErr != nil {
+				fmt.Printf("Failed to run scheduled task immediately: %v\nOutput: %s\n", runErr, runOutput)
+			} else {
+				fmt.Println("Scheduled task started immediately.")
+			}
 		} else {
 			fmt.Print("Enter the user for the systemd service (default: root): ")
 			scanner := bufio.NewScanner(os.Stdin)
@@ -168,7 +204,7 @@ var buildCmd = &cobra.Command{
 func loadConfig() Config {
 	var configPath string
 	if runtime.GOOS == "windows" {
-		configPath = filepath.Join(os.Getenv("ProgramData"), "updatectl", "updatectl.yaml")
+		configPath = filepath.Join(os.Getenv("USERPROFILE"), "updatectl", "updatectl.yaml")
 	} else {
 		configPath = "/etc/updatectl/updatectl.yaml"
 	}