-
Notifications
You must be signed in to change notification settings - Fork 13
Update tutorials #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tutorials #45
Conversation
|
@Sorixelle Seems GitHub's auto-merge main feature doesn't add the signed off by. Is that still an issue? |
|
@Sorixelle De-scoping the "Advanced Tutorials" section that contains only the PDC tutorial because it requires some files that I can't find anymore - broken link to the Pebble S3. It can be done in a follow-up PR. |
It is annoying but the checks don't like it, yeah. Generally, prefer rebases over merging to update a branch - it doesn't create an extra commit. Sorry it's taken me so long to get to this one - gotta find time to properly look through the changes. |
Gotcha, I'll update it soon. Thanks for your review! No problem 😄 |
54e0837 to
2443388
Compare
|
@Sorixelle Things seem happier now! |
60bb24e to
b45f2cf
Compare
|
@Sorixelle Fixed lint error! Good to merge now I think! |
Sorixelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whew, sorry for taking so, so long to get around to this one. It's looking good, and I'm not fundamentally opposed to the changes. There's a few bits that need some cleanup though, I've left a handful of comments.
|
@Sorixelle Addressed the suggested changes or otherwise left comments in response. Please take a look again when able! |
|
@Sorixelle Ready to land! Thanks for looking at this one :) |
Sorixelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one tiny nitpick left, then we should be good to go!
Sorixelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this one on!
Signed-off-by: C-D-Lewis <[email protected]>
Signed-off-by: C-D-Lewis <[email protected]>
Signed-off-by: C-D-Lewis <[email protected]>
Signed-off-by: C-D-Lewis <[email protected]>
dfc1523 to
f483700
Compare
Goes some way to fixing #44 by testing creating projects from the snippets, and fixing dead links and small errors in code.
Also includes full source-code files as an expandable at the end instead of relying on a third-party Gist.
Advanced tutorials?Requires missing example files (PDC SVG Zip file)