Skip to content

Conversation

@C-D-Lewis
Copy link
Contributor

@C-D-Lewis C-D-Lewis commented Aug 14, 2025

Goes some way to fixing #44 by testing creating projects from the snippets, and fixing dead links and small errors in code.

Also includes full source-code files as an expandable at the end instead of relying on a third-party Gist.

  • Fix way outdated mobile nav
  • C tutorial
  • JS tutorial
  • Advanced tutorials? Requires missing example files (PDC SVG Zip file)

@C-D-Lewis
Copy link
Contributor Author

@Sorixelle Seems GitHub's auto-merge main feature doesn't add the signed off by. Is that still an issue?

@C-D-Lewis
Copy link
Contributor Author

@Sorixelle De-scoping the "Advanced Tutorials" section that contains only the PDC tutorial because it requires some files that I can't find anymore - broken link to the Pebble S3. It can be done in a follow-up PR.

@Sorixelle
Copy link
Member

Sorixelle commented Aug 31, 2025

Seems GitHub's auto-merge main feature doesn't add the signed off by. Is that still an issue?

It is annoying but the checks don't like it, yeah. Generally, prefer rebases over merging to update a branch - it doesn't create an extra commit.

Sorry it's taken me so long to get to this one - gotta find time to properly look through the changes.

@C-D-Lewis
Copy link
Contributor Author

Seems GitHub's auto-merge main feature doesn't add the signed off by. Is that still an issue?

It is annoying but the checks don't like it, yeah. Generally, prefer rebases over merging to update a branch - it doesn't create an extra commit.

Sorry it's taken me so long to get to this one - gotta find time to properly look through the changes.

Gotcha, I'll update it soon. Thanks for your review! No problem 😄

@C-D-Lewis
Copy link
Contributor Author

@Sorixelle Things seem happier now!

@C-D-Lewis
Copy link
Contributor Author

@Sorixelle Fixed lint error! Good to merge now I think!

Copy link
Member

@Sorixelle Sorixelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew, sorry for taking so, so long to get around to this one. It's looking good, and I'm not fundamentally opposed to the changes. There's a few bits that need some cleanup though, I've left a handful of comments.

@C-D-Lewis
Copy link
Contributor Author

@Sorixelle Addressed the suggested changes or otherwise left comments in response. Please take a look again when able!

@C-D-Lewis
Copy link
Contributor Author

@Sorixelle Ready to land! Thanks for looking at this one :)

Copy link
Member

@Sorixelle Sorixelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny nitpick left, then we should be good to go!

Copy link
Member

@Sorixelle Sorixelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this one on!

C-D-Lewis and others added 4 commits November 8, 2025 09:05
Signed-off-by: C-D-Lewis <[email protected]>
Signed-off-by: C-D-Lewis <[email protected]>
@Sorixelle Sorixelle merged commit 2c0e6df into pebble-dev:main Nov 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants