CreateService() requires admin rights

Calling Win32::Daemon::CreateService() without sufficient privileges
was resulting in uninformative "The operation completed successfully"
error.

Lack of meaningful error message was caused by not calling
GetLastError() after OpenSCManager() failure.

Resolves RT#73715, RT#86501 and RT#86882.

Author: xenu

Changes

@@ -10,6 +10,8 @@ Revision history for Perl extension {{$dist->name}}
     - Move Daemon.pm to its proper spot in the lib/Win32 directory
     - Take Cygwin out of the supported OSes as there are many compilation errors
       at the moment. Please submit a PR if you are capable of fixing this!
+    - Document that CreateService() requires admin rights and don't hide
+      "permission denied" error (RT #73715, RT #86501 and RT #86882)
 
 20131206  2013-12-06
     - Fix required perl version 5.6 -> 5.006

Daemon.h

@@ -144,6 +144,10 @@
                                                 gdwLastError = GetLastError();                              \
                                             }                                                               \
                                             CloseServiceHandle( hSc );                                      \
+                                        }                                                                   \
+                                        else                                                                \
+                                        {                                                                   \
+                                                gdwLastError = GetLastError();                              \
                                         }
 
 

lib/Win32/Daemon.pm

@@ -264,6 +264,9 @@ This function creates a new service in the system configuration. The
 return is TRUE if the service was created, and FALSE otherwise. If an error
 occurred, call GetLastError to retrieve the actual error code.
 
+B<NOTE:> This function will fail if the script is not running with administrator
+privileges.
+
 The hash describes the service to be created. The keys are:
 
 =over 4