From eba8feacf79a570628e668f73eebe9c123629fb8 Mon Sep 17 00:00:00 2001 From: Neil Daniels Date: Wed, 29 Jan 2025 17:48:28 -0800 Subject: [PATCH 1/2] Bump actions/upload-artifact version --- .github/workflows/continuous-integration.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index 0147e2a2..349b15fd 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -84,7 +84,7 @@ jobs: run: "vendor/bin/phpunit --coverage-clover=coverage.xml" - name: "Upload coverage file" - uses: "actions/upload-artifact@v2" + uses: "actions/upload-artifact@v4" with: name: "phpunit-${{ matrix.php-version }}-${{ matrix.deps }}-${{ hashFiles('composer.lock') }}.coverage" path: "coverage.xml" From e9337b77bce5feea3a5bb19ab739e7c8f98f60ba Mon Sep 17 00:00:00 2001 From: Neil Daniels Date: Wed, 29 Jan 2025 17:55:32 -0800 Subject: [PATCH 2/2] PHPStan fixes --- .../Listener/Request/SessionTokenRequestListener.php | 2 +- phpstan-baseline.neon | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/lib/Tmdb/Event/Listener/Request/SessionTokenRequestListener.php b/lib/Tmdb/Event/Listener/Request/SessionTokenRequestListener.php index 8bd09d0e..9889c8ab 100644 --- a/lib/Tmdb/Event/Listener/Request/SessionTokenRequestListener.php +++ b/lib/Tmdb/Event/Listener/Request/SessionTokenRequestListener.php @@ -23,7 +23,7 @@ class SessionTokenRequestListener { /** - * @var string|SessionBearerToken|GuestSessionToken + * @var SessionBearerToken|GuestSessionToken */ private $token; diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index 6bd7c97d..a9e9f628 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -54,14 +54,6 @@ parameters: count: 1 path: lib/Tmdb/Model/Movie.php - - - message: """ - #^Call to deprecated method getReleases\\(\\) of class Tmdb\\\\Model\\\\Movie\\: - Use the getReleaseDates instead$# - """ - count: 1 - path: lib/Tmdb/Repository/MovieRepository.php - - message: """ #^Return type of method Tmdb\\\\Repository\\\\MovieRepository\\:\\:getReleases\\(\\) has typehint with deprecated class Tmdb\\\\Model\\\\Movie\\\\Release\\: