Fix GH-20374: PHP with tidy and custom-tags #20379
Closed
+200
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both enums and integers map to TidyInteger, however, in the TidyInteger case we always used zval_get_long(). So for a non-numeric string, this would get turned into 0. 0 is the first enum value in that case, so the wrong enum value could be selected. To solve this, add special handling for strings and (stringable) objects such that we can explicitly check for numeric strings, and if they're not, handle them as normal strings instead of as 0.
devnexen
reviewed
Nov 3, 2025
devnexen
approved these changes
Nov 3, 2025
Girgias
reviewed
Nov 4, 2025
| 'int' => 1, | ||
| 'double overflow' => (string) (2.0**80.0), | ||
| 'numeric string int 1' => '1', | ||
| 'numeric string double 1.0' => '1.0', |
There was a problem hiding this comment.
Can I be annoying and ask you to have test cases for INF and NAN? :)
Actually curious what the behaviour would be.
There was a problem hiding this comment.
Pushed. Apparently: nothing meaningful as they get turned into (int)0.
Girgias
approved these changes
Nov 4, 2025
|
Merged via fcc159b etc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both enums and integers map to TidyInteger, however, in the TidyInteger case we always used zval_get_long(). So for a non-numeric string, this would get turned into 0. 0 is the first enum value in that case, so the wrong enum value could be selected.
To solve this, add special handling for strings and (stringable) objects such that we can explicitly check for numeric strings, and if they're not, handle them as normal strings instead of as 0.