Merge pull request #516 from phpmetrics/fix/externals-visitor

Fix/externals visitor

Author: niconoe-

.semver

@@ -2,4 +2,4 @@
 :major: 3
 :minor: 0
 :patch: 0
-:special: rc6
+:special: rc7

artifacts/bintray.json

@@ -10,10 +10,10 @@
     "licenses": ["MIT"]
   },
   "version": {
-    "name": "v3.0.0rc6",
+    "name": "v3.0.0rc7",
     "desc": "Latest version of PhpMetrics",
-    "released": "2024-02-08",
-    "vcs_tag": "v3.0.0rc6",
+    "released": "2025-02-04",
+    "vcs_tag": "v3.0.0rc7",
     "attributes": [],
     "gpgSign": false
   },

composer.json

@@ -44,7 +44,7 @@
         "squizlabs/php_codesniffer": "^3.11",
         "symfony/dom-crawler": "^6.4",
         "roave/security-advisories": "dev-latest",
-        "vimeo/psalm": "^6.2"
+        "vimeo/psalm": "^6.3"
     },
     "bin": [
         "bin/phpmetrics"

qa/Dockerfile

@@ -35,10 +35,10 @@ RUN apk update && \
     # Allow phar writing.
     echo 'phar.readonly=0' >> ${PHP_INI_DIR}/conf.d/docker-php-phar-readonly.ini && \
     # Fetching the PHP Infection from release to fetch.
-    echo "Looking for the latest PHP Infection 0.29.x version…" && \
-    RELEASES=$(curl -sS https://api.github.com/repos/infection/infection/releases | jq --compact-output --raw-output 'map(select( .tag_name | test("^0.29.[0-9]+$") ))') && \
+    echo "Looking for the latest PHP Infection 0.28.x version…" && \
+    RELEASES=$(curl -sS https://api.github.com/repos/infection/infection/releases | jq --compact-output --raw-output 'map(select( .tag_name | test("^0.28.[0-9]+$") ))') && \
     NB_RELEASES=$(echo "${RELEASES}" | jq --compact-output --raw-output 'length') && \
-    if [ "${NB_RELEASES}" == "0" ]; then echo "ERROR: Not a single patch version found for minor version 0.29 of PHP Infection."; exit 1; fi && \
+    if [ "${NB_RELEASES}" == "0" ]; then echo "ERROR: Not a single patch version found for minor version 0.28 of PHP Infection."; exit 1; fi && \
     LATEST_FOR_MINOR=$(echo "${RELEASES}" | jq --compact-output --raw-output '. | max_by( .tag_name | split(".") | map(tonumber) ) | {tag: .tag_name, src: .assets[]|select(.name == "infection.phar").browser_download_url}') && \
     INFECTION_TAG=$(echo "${LATEST_FOR_MINOR}" | jq --compact-output --raw-output '.tag') && \
     URL_SRC=$(echo "${LATEST_FOR_MINOR}" | jq --compact-output --raw-output '.src') && \

qa/psalm-baseline.xml

@@ -35,9 +35,9 @@
     </PropertyTypeCoercion>
   </file>
   <file src="../src/Hal/Metric/Class_/Coupling/ExternalsVisitor.php">
-    <PossiblyUndefinedArrayOffset>
-      <code><![CDATA[$resolvedClassName]]></code>
-    </PossiblyUndefinedArrayOffset>
+    <PossiblyFalseOperand>
+      <code><![CDATA[strstr($classNameToResolve, '\\')]]></code>
+    </PossiblyFalseOperand>
     <UndefinedPropertyFetch>
       <code><![CDATA[$node->class]]></code>
     </UndefinedPropertyFetch>

releases/phpmetrics.phar

@@ -13,7 +13,6 @@
 use PhpParser\NodeVisitorAbstract;
 use Stringable;
 use function array_map;
-use function explode;
 use function in_array;
 use function ltrim;
 use function preg_match_all;
@@ -237,9 +236,8 @@ private function resolveClassName(string $classNameToResolve): null|string
             if ($useAlias === $classNameToResolve && !str_contains($classNameToResolve, '\\')) {
                 return (string)$use->name;
             }
-            [$resolvedAlias, $resolvedClassName] = explode('\\', $classNameToResolve, 2);
-            if ($useAlias === $resolvedAlias) {
-                return $use->name . '\\' . $resolvedClassName;
+            if ($useAlias === strstr($classNameToResolve, '\\', true)) {
+                return $use->name . strstr($classNameToResolve, '\\');
             }
         }