-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
never-staleUse this label to ensure the stale action does not close this issueUse this label to ensure the stale action does not close this issue
Description
This is a: Documentation Error
Details
This section is inaccurate on modern Fedora, it might be written with Ubuntu in mind
https://github.com/pi-hole/docker-pi-hole/tree/4cb3c3a16d4d571408f83640487017799402b50b?tab=readme-ov-file#installing-on-ubuntu-or-fedora
There are two issues that stand out to me:
- As far as I know, modern Fedora does not ship with
netplan
, sosystemd-resolved
on Fedora cannot use it by default. I do not know enough aboutnetplan
to say if installing it is sufficient to fix this or if that requires configuration. - About the line
sudo sed -r -i.orig 's/#?DNSStubListener=yes/DNSStubListener=no/g' /etc/systemd/resolved.conf
; it might be worth mentioning that (as far as I know, at least on some versions),/etc/systemd/resolved.conf
might not exist by default; a template for it can be copied into/etc/systemd/resolved.conf
from/usr/lib/systemd/resolved.conf
. I believe this change was made in Fedora 40? I think a better option would just be:
$ [ -d /etc/systemd/resolved.conf.d ] || sudo mkdir /etc/systemd/resolved.conf.d
$ echo '[Resolve]' | sudo tee /etc/systemd/resolved.conf.d/10-pihole.conf
$ echo 'DNSStubListener=no' | sudo tee -a /etc/systemd/resolved.conf.d/10-pihole.conf
This stack overflow post seems to indicate that
https://unix.stackexchange.com/questions/761092/fedora-systemd-resolved
Related Issues
- I have searched this repository/Pi-hole forums for existing issues and pull requests that look similar
This #1365 is about a README overhaul in general, but the description is mostly empty so I am assuming it is not talking about this issue
Environment data
- Operating Systems: Fedora Workstation 40, Fedora Cloud 41, Fedora Minimal 41
kotx
Metadata
Metadata
Assignees
Labels
never-staleUse this label to ensure the stale action does not close this issueUse this label to ensure the stale action does not close this issue