Skip to content

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Aug 6, 2025

Adds the FTL bash completion to the image. Depends on pi-hole/pi-hole#6376

@yubiuser yubiuser requested a review from a team as a code owner August 6, 2025 12:04
@yubiuser yubiuser marked this pull request as draft August 6, 2025 12:07
@yubiuser
Copy link
Member Author

yubiuser commented Aug 6, 2025

Un-draft once the core PR has been merged. Otherwise test will always fail.

@yubiuser yubiuser marked this pull request as ready for review August 18, 2025 17:59
@yubiuser
Copy link
Member Author

Core and FTL branch have been merged into development.

@rdwebdesign
Copy link
Member

Are you sure this is needed?

I think the Core PR will already install the files.

@yubiuser
Copy link
Member Author

If we want the feature on docker, we need this PR. On bare metall the completion file is installed with the installer, but on docker we don't run the installer and therefore need to copy the file manually.
We do the same for 'pihole' bash completion already

Copy link
Member

@PromoFaux PromoFaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also fix failing nightly builds

@PromoFaux PromoFaux merged commit 763b945 into development Aug 25, 2025
12 checks passed
@PromoFaux PromoFaux deleted the autocomplete branch August 25, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants