[Bug] AssetMetaData language and name are switched (#218)

* fix: metadata fields are listed as field name and language

* use better variable naming

* fix failing test issues

Author: lukmzig

.github/workflows/static-analysis.yaml

@@ -60,7 +60,7 @@ jobs:
 
             - name: "Upload baseline file"
               if: ${{ failure() }}
-              uses: actions/upload-artifact@v2
+              uses: actions/upload-artifact@v4
               with:
                   name: phpstan-baseline.neon
                   path: phpstan-baseline.neon

composer.json

@@ -26,7 +26,6 @@
     "symfony/messenger": "^6.4"
   },
   "require-dev": {
-    "roave/security-advisories": "dev-latest",
     "codeception/codeception": "^5.0.10",
     "codeception/phpunit-wrapper": "^9",
     "codeception/module-asserts": "^2",

src/Service/Serializer/Denormalizer/Search/AssetSearchResultDenormalizer.php

@@ -84,12 +84,11 @@ private function hydrateMetadata(array $standardFields): array
     {
         $result = [];
 
-        foreach ($standardFields as $language => $fields) {
-            foreach ($fields as $fieldName => $fieldData) {
-
+        foreach ($standardFields as $fieldName => $data) {
+            foreach ($data as $languageKey => $fieldData) {
                 $result[] = new AssetMetaData(
                     name: $fieldName,
-                    language: $language !== MappingProperty::NOT_LOCALIZED_KEY ? $language : null,
+                    language: $languageKey !== MappingProperty::NOT_LOCALIZED_KEY ? $languageKey : null,
                     data: $fieldData,
                 );
             }