Update Bool filter to check if the boolean field is empty (#342)

* Update Bool filter to check if the boolean field is empty

* Remove Test

* Tests

* Remove Tests again

* Fix Logic

* Apply php-cs-fixer changes

* Fix Logic

* Apply php-cs-fixer changes

---------

Co-authored-by: martineiber <[email protected]>

Author: martineiber

src/Model/DefaultSearch/Query/BoolExistsQuery.php

@@ -0,0 +1,49 @@
+<?php
+declare(strict_types=1);
+
+/**
+ * This source file is available under the terms of the
+ * Pimcore Open Core License (POCL)
+ * Full copyright and license information is available in
+ * LICENSE.md which is distributed with this source code.
+ *
+ *  @copyright  Copyright (c) Pimcore GmbH (https://www.pimcore.com)
+ *  @license    Pimcore Open Core License (POCL)
+ */
+
+namespace Pimcore\Bundle\GenericDataIndexBundle\Model\DefaultSearch\Query;
+
+use Pimcore\Bundle\GenericDataIndexBundle\Enum\SearchIndex\DefaultSearch\ConditionType;
+
+final class BoolExistsQuery extends BoolQuery implements AsSubQueryInterface
+{
+    public function __construct(
+        private readonly string $field
+    ) {
+        parent::__construct([
+            ConditionType::FILTER->value => [
+                'bool' => [
+                    'must_not' => [
+                        'exists' => ['field' => $field],
+                    ],
+                ],
+            ],
+        ]);
+    }
+
+    public function getField(): string
+    {
+        return $this->field;
+    }
+
+    public function toArrayAsSubQuery(): array
+    {
+        return [
+            'bool' => [
+                'must_not' => [
+                    'exists' => ['field' => $this->field],
+                ],
+            ],
+        ];
+    }
+}

src/Model/Search/Modifier/Filter/Basic/BooleanFilter.php

@@ -19,7 +19,7 @@
 {
     public function __construct(
         private string $fieldName,
-        private bool $searchTerm,
+        private null|bool $searchTerm,
         private bool $enablePqlFieldNameResolution = true,
     ) {
     }
@@ -29,7 +29,7 @@ public function getFieldName(): string
         return $this->fieldName;
     }
 
-    public function getSearchTerm(): bool
+    public function getSearchTerm(): null|bool
     {
         return $this->searchTerm;
     }

src/SearchIndexAdapter/DefaultSearch/Search/Modifier/Filter/BasicFilters.php

@@ -16,6 +16,7 @@
 use Pimcore\Bundle\GenericDataIndexBundle\Attribute\Search\AsSearchModifierHandler;
 use Pimcore\Bundle\GenericDataIndexBundle\Enum\SearchIndex\FieldCategory\SystemField;
 use Pimcore\Bundle\GenericDataIndexBundle\Model\DefaultSearch\Modifier\SearchModifierContextInterface;
+use Pimcore\Bundle\GenericDataIndexBundle\Model\DefaultSearch\Query\BoolExistsQuery;
 use Pimcore\Bundle\GenericDataIndexBundle\Model\DefaultSearch\Query\BoolQuery;
 use Pimcore\Bundle\GenericDataIndexBundle\Model\DefaultSearch\Query\TermFilter;
 use Pimcore\Bundle\GenericDataIndexBundle\Model\DefaultSearch\Query\TermsFilter;
@@ -77,11 +78,19 @@ public function handleBooleanFilter(BooleanFilter $booleanFilter, SearchModifier
             );
         }
 
-        $context->getSearch()->addQuery(
-            new TermFilter(
+        $query = new BoolExistsQuery(
+            field: $fieldName,
+        );
+
+        if ($booleanFilter->getSearchTerm() !== null) {
+            $query = new TermFilter(
                 field: $fieldName,
                 term: $booleanFilter->getSearchTerm(),
-            )
+            );
+        }
+
+        $context->getSearch()->addQuery(
+            $query
         );
     }