Skip to content

Commit 22f8bad

Browse files
committed
Only Exclude those from test.
1 parent e54f246 commit 22f8bad

13 files changed

+21
-53
lines changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"minimum-stability": "dev",
2525
"require": {
2626
"php": "~8.3.0 || ~8.4.0",
27-
"pimcore/pimcore": "12.x-dev",
27+
"pimcore/pimcore": "^12.1",
2828
"friendsofphp/proxy-manager-lts": "^1"
2929
},
3030
"require-dev": {

src/Models/Asset/AssetResolver.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,4 @@ public function getTypeFromMimeMapping(string $mimeType, string $filename): stri
2525
{
2626
return Asset::getTypeFromMimeMapping($mimeType, $filename);
2727
}
28-
public function setGetInheritedProperties(bool $getInheritedProperties): void
29-
{
30-
Asset::setGetInheritedProperties($getInheritedProperties);
31-
}
32-
33-
public function getGetInheritedProperties(): bool
34-
{
35-
return Asset::getGetInheritedProperties();
36-
}
3728
}

src/Models/Asset/AssetResolverInterface.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,4 @@
2121
interface AssetResolverInterface extends AssetResolverContractInterface
2222
{
2323
public function getTypeFromMimeMapping(string $mimeType, string $filename): string;
24-
25-
public function setGetInheritedProperties(bool $getInheritedProperties): void;
26-
27-
public function getGetInheritedProperties(): bool;
2824
}

src/Models/DataObject/ConcreteObjectResolver.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,4 @@
2121
*/
2222
final class ConcreteObjectResolver extends ConcreteObjectResolverContract implements ConcreteObjectResolverInterface
2323
{
24-
public function setGetInheritedProperties(bool $getInheritedProperties): void
25-
{
26-
Concrete::setGetInheritedProperties($getInheritedProperties);
27-
}
28-
29-
public function getGetInheritedProperties(): bool
30-
{
31-
return Concrete::getGetInheritedProperties();
32-
}
3324
}

src/Models/DataObject/ConcreteObjectResolverInterface.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,4 @@
2020
*/
2121
interface ConcreteObjectResolverInterface extends ConcreteObjectResolverContractInterface
2222
{
23-
public function setGetInheritedProperties(bool $getInheritedProperties): void;
24-
25-
public function getGetInheritedProperties(): bool;
2623
}

src/Models/DataObject/DataObjectFolderResolver.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,4 @@
2121
*/
2222
final class DataObjectFolderResolver extends DataObjectFolderResolverContract implements DataObjectFolderResolverInterface
2323
{
24-
public function setGetInheritedProperties(bool $getInheritedProperties): void
25-
{
26-
Folder::setGetInheritedProperties($getInheritedProperties);
27-
}
28-
29-
public function getGetInheritedProperties(): bool
30-
{
31-
return Folder::getGetInheritedProperties();
32-
}
3324
}

src/Models/DataObject/DataObjectFolderResolverInterface.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,4 @@
2020
*/
2121
interface DataObjectFolderResolverInterface extends DataObjectFolderResolverContractInterface
2222
{
23-
public function setGetInheritedProperties(bool $getInheritedProperties): void;
24-
25-
public function getGetInheritedProperties(): bool;
2623
}

src/Models/DataObject/DataObjectResolver.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,4 @@
2121
*/
2222
final class DataObjectResolver extends DataObjectResolverContract implements DataObjectResolverInterface
2323
{
24-
public function setGetInheritedProperties(bool $getInheritedProperties): void
25-
{
26-
DataObject::setGetInheritedProperties($getInheritedProperties);
27-
}
28-
29-
public function getGetInheritedProperties(): bool
30-
{
31-
return DataObject::getGetInheritedProperties();
32-
}
3324
}

src/Models/DataObject/DataObjectResolverInterface.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,4 @@
2020
*/
2121
interface DataObjectResolverInterface extends DataObjectResolverContractInterface
2222
{
23-
public function setGetInheritedProperties(bool $getInheritedProperties): void;
24-
25-
public function getGetInheritedProperties(): bool;
2623
}

tests/Unit/Models/Assets/AssetResolverTest.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,11 @@
1111
#[Group('contract')]
1212
class AssetResolverTest extends ContractAbstractTest
1313
{
14+
public array $excludedMethods = [
15+
'setGetInheritedProperties',
16+
'getGetInheritedProperties'
17+
];
18+
1419
public array $exludeMethodsForReturnTypeCheck = ['getByPath', 'getById'];
1520

1621
protected function getClassToTest(): string {

0 commit comments

Comments
 (0)