Skip to content

Commit 4a37caf

Browse files
herbertrothclaude
andcommitted
Fix PHPStan errors in hardlink wrapper resolver contracts
- Remove undefined setGetInheritedValues and getGetInheritedValues methods from Folder, Hardlink, and Link resolver contracts - Update corresponding contract interfaces to match - These methods don't exist in the underlying Pimcore wrapper classes unlike other document types - Resolves 6 PHPStan static analysis errors 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 6368c31 commit 4a37caf

File tree

6 files changed

+0
-36
lines changed

6 files changed

+0
-36
lines changed

src/Contract/Models/Document/Hardlink/Wrapper/FolderResolverContract.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -67,13 +67,4 @@ public function locateDaoClass(string $modelClass): ?string
6767
return Folder::locateDaoClass($modelClass);
6868
}
6969

70-
public function setGetInheritedValues(bool $getInheritedValues): void
71-
{
72-
Folder::setGetInheritedValues($getInheritedValues);
73-
}
74-
75-
public function getGetInheritedValues(): bool
76-
{
77-
return Folder::getGetInheritedValues();
78-
}
7970
}

src/Contract/Models/Document/Hardlink/Wrapper/FolderResolverContractInterface.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,4 @@ public function doHideUnpublished(): bool;
4040

4141
public function locateDaoClass(string $modelClass): ?string;
4242

43-
public function setGetInheritedValues(bool $getInheritedValues): void;
44-
45-
public function getGetInheritedValues(): bool;
4643
}

src/Contract/Models/Document/Hardlink/Wrapper/HardlinkResolverContract.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -67,13 +67,4 @@ public function locateDaoClass(string $modelClass): ?string
6767
return Hardlink::locateDaoClass($modelClass);
6868
}
6969

70-
public function setGetInheritedValues(bool $getInheritedValues): void
71-
{
72-
Hardlink::setGetInheritedValues($getInheritedValues);
73-
}
74-
75-
public function getGetInheritedValues(): bool
76-
{
77-
return Hardlink::getGetInheritedValues();
78-
}
7970
}

src/Contract/Models/Document/Hardlink/Wrapper/HardlinkResolverContractInterface.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,4 @@ public function doHideUnpublished(): bool;
4040

4141
public function locateDaoClass(string $modelClass): ?string;
4242

43-
public function setGetInheritedValues(bool $getInheritedValues): void;
44-
45-
public function getGetInheritedValues(): bool;
4643
}

src/Contract/Models/Document/Hardlink/Wrapper/LinkResolverContract.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -67,13 +67,4 @@ public function locateDaoClass(string $modelClass): ?string
6767
return Link::locateDaoClass($modelClass);
6868
}
6969

70-
public function setGetInheritedValues(bool $getInheritedValues): void
71-
{
72-
Link::setGetInheritedValues($getInheritedValues);
73-
}
74-
75-
public function getGetInheritedValues(): bool
76-
{
77-
return Link::getGetInheritedValues();
78-
}
7970
}

src/Contract/Models/Document/Hardlink/Wrapper/LinkResolverContractInterface.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,4 @@ public function doHideUnpublished(): bool;
4040

4141
public function locateDaoClass(string $modelClass): ?string;
4242

43-
public function setGetInheritedValues(bool $getInheritedValues): void;
44-
45-
public function getGetInheritedValues(): bool;
4643
}

0 commit comments

Comments
 (0)