Skip to content

Commit d44bb8b

Browse files
committed
Add all public non-internal static functions to contracts.
Add test to ensure this.
1 parent b63ba03 commit d44bb8b

File tree

5 files changed

+86
-7
lines changed

5 files changed

+86
-7
lines changed
Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
<?php
2+
declare(strict_types=1);
3+
4+
namespace Pimcore\Bundle\StaticResolverBundle\Contract\Models\DataObject;
5+
6+
use Pimcore\Model\DataObject\Localizedfield;
7+
8+
class LocalizedFieldResolverContract implements LocalizedFieldResolverContractInterface
9+
{
10+
11+
public function setGetFallbackValues(bool $getFallbackValues): void
12+
{
13+
Localizedfield::setGetFallbackValues($getFallbackValues);
14+
}
15+
16+
public function getGetFallbackValues(): bool
17+
{
18+
return Localizedfield::getGetFallbackValues();
19+
}
20+
21+
public function isStrictMode(): bool
22+
{
23+
return Localizedfield::isStrictMode();
24+
}
25+
26+
public function setStrictMode(bool $strictMode): void
27+
{
28+
Localizedfield::setStrictMode($strictMode);
29+
}
30+
31+
public function doGetFallbackValues(): bool
32+
{
33+
return Localizedfield::doGetFallbackValues();
34+
}
35+
36+
public function locateDaoClass(string $modelClass): ?string
37+
{
38+
return Localizedfield::locateDaoClass($modelClass);
39+
}
40+
41+
}
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
<?php
2+
declare(strict_types=1);
3+
4+
namespace Pimcore\Bundle\StaticResolverBundle\Contract\Models\DataObject;
5+
6+
interface LocalizedFieldResolverContractInterface
7+
{
8+
public function setGetFallbackValues(bool $getFallbackValues): void;
9+
10+
public function getGetFallbackValues(): bool;
11+
12+
public function isStrictMode(): bool;
13+
14+
public function setStrictMode(bool $strictMode): void;
15+
16+
public function doGetFallbackValues(): bool;
17+
18+
public function locateDaoClass(string $modelClass): ?string;
19+
}

src/Models/DataObject/LocalizedFieldResolver.php

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,12 @@
1616

1717
namespace Pimcore\Bundle\StaticResolverBundle\Models\DataObject;
1818

19+
use Pimcore\Bundle\StaticResolverBundle\Contract\Models\DataObject\LocalizedFieldResolverContract;
1920
use Pimcore\Model\DataObject\Localizedfield;
2021

2122
/**
2223
* @internal
2324
*/
24-
final class LocalizedFieldResolver implements LocalizedFieldResolverInterface
25+
final class LocalizedFieldResolver extends LocalizedFieldResolverContract implements LocalizedFieldResolverInterface
2526
{
26-
public function setGetFallbackValues(bool $getFallbackValues): void
27-
{
28-
Localizedfield::setGetFallbackValues($getFallbackValues);
29-
}
3027
}

src/Models/DataObject/LocalizedFieldResolverInterface.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,11 @@
1616

1717
namespace Pimcore\Bundle\StaticResolverBundle\Models\DataObject;
1818

19+
use Pimcore\Bundle\StaticResolverBundle\Contract\Models\DataObject\LocalizedFieldResolverContractInterface;
20+
1921
/**
2022
* @internal
2123
*/
22-
interface LocalizedFieldResolverInterface
24+
interface LocalizedFieldResolverInterface extends LocalizedFieldResolverContractInterface
2325
{
24-
public function setGetFallbackValues(bool $getFallbackValues): void;
2526
}
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
<?php
2+
declare(strict_types=1);
3+
4+
namespace Pimcore\Bundle\StaticResolverBundle\Tests\Unit\Models\DataObject;
5+
6+
use Codeception\Attribute\Group;
7+
use Pimcore\Bundle\StaticResolverBundle\Contract\Models\DataObject\LocalizedFieldResolverContract;
8+
use Pimcore\Bundle\StaticResolverBundle\Tests\Unit\TestTools\ContractAbstractTest;
9+
use Pimcore\Model\DataObject\Localizedfield;
10+
11+
#[Group('contract')]
12+
class LocalizedFieldResolverTest extends ContractAbstractTest
13+
{
14+
protected function getClassToTest(): string {
15+
return Localizedfield::class;
16+
}
17+
18+
protected function getContractToTest(): string {
19+
return LocalizedFieldResolverContract::class;
20+
}
21+
}

0 commit comments

Comments
 (0)