Changes from PR and Changelog entry

Author: MrTeale

CHANGELOG.md

@@ -10,6 +10,10 @@ This project adheres to [Semantic Versioning](https://semver.org/).
 [#2003](https://github.com/plotly/dash/issues/2003) in which 
 `dangerously_allow_html=True` + `mathjax=True` works in some cases, and in some cases not.
 
+### Changed
+
+- [#2050](https://github.com/plotly/dash/pull/2050) Changed `find_element` and `find_elements` to accept an `attribute` argument that aligns with Selenium's `By` class, allowing you to search elements by other attributes. Default value is `CSS_SELECTOR` to maintain backwards compatibility with previous `find_elements`.
+
 ## [2.4.1] - 2022-05-11
 
 ### Fixed

dash/testing/browser.py

@@ -230,13 +230,23 @@ def take_snapshot(self, name):
 
     def find_element(self, selector, attribute="CSS_SELECTOR"):
         """find_element returns the first found element by the attribute `selector`
-        shortcut to `driver.find_element(By.CSS_SELECTOR, ...)`."""
+        shortcut to `driver.find_element(By.CSS_SELECTOR, ...)`.
+        args:
+        - attribute: the attribute type to search for, aligns with the Selenium
+            API's `By` class. default "CSS_SELECTOR"
+            valid values: "CSS_SELECTOR", "ID", "NAME", "TAG_NAME",
+            "CLASS_NAME", "LINK_TEXT", "PARTIAL_LINK_TEXT", "XPATH"
+        """
         return self.driver.find_element(getattr(By, attribute.upper()), selector)
 
     def find_elements(self, selector, attribute="CSS_SELECTOR"):
         """find_elements returns a list of all elements matching the attribute
-        `selector`
-        shortcut to `driver.find_elements(By.CSS_SELECTOR, ...)`.
+        `selector`. Shortcut to `driver.find_elements(By.CSS_SELECTOR, ...)`.
+        args:
+        - attribute: the attribute type to search for, aligns with the Selenium
+            API's `By` class. default "CSS_SELECTOR"
+            valid values: "CSS_SELECTOR", "ID", "NAME", "TAG_NAME",
+            "CLASS_NAME", "LINK_TEXT", "PARTIAL_LINK_TEXT", "XPATH"
         """
         return self.driver.find_elements(getattr(By, attribute.upper()), selector)
 
@@ -450,10 +460,7 @@ def _get_chrome(self):
         options.add_argument("--remote-debugging-port=9222")
 
         chrome = (
-            webdriver.Remote(
-                command_executor=self._remote_url,
-                options=options
-            )
+            webdriver.Remote(command_executor=self._remote_url, options=options)
             if self._remote
             else webdriver.Chrome(options=options)
         )

tests/integration/devtools/test_devtools_ui.py

@@ -256,4 +256,4 @@ def create_an_alternative_response():
     )
 
     driver.get(dash_thread_server.url)
-    dash_br.find_element("alternative_id", attribute="ID")
+    dash_br.find_element("#alternative_id")