Skip to content

Commit 62cf1df

Browse files
authored
Merge pull request #1932 from plotly/fix-ie11
Fix IE11
2 parents 8ff71f7 + 451ea2f commit 62cf1df

24 files changed

+360
-436
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,12 @@ This project adheres to [Semantic Versioning](https://semver.org/).
1717
- Adds `ticklabelstep` to axes to reduce tick labels while still showing all ticks.
1818
- Displays the plotly.js version when hovering on the modebar. This helps debugging situations where there might be multiple sources of plotly.js, for example `/assets` vs the versions built into `dcc` or `ddk`.
1919

20+
### Fixed
21+
- [#1932](https://github.com/plotly/dash/pull/1932) Fixes several bugs:
22+
- Restores compatibility with IE11 [#1925](https://github.com/plotly/dash/issues/1925)
23+
- Restores `style_header` text alignment in Dash Table [#1914](https://github.com/plotly/dash/issues/1914)
24+
- Clears the unneeded `webdriver-manager` requirement from `dash[testing]` [#1919](https://github.com/plotly/dash/issues/1925)
25+
2026
## [2.1.0] - 2022-01-22
2127

2228
### Changed

components/dash-core-components/package-lock.json

Lines changed: 33 additions & 33 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

components/dash-core-components/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@
3636
"maintainer": "Alex Johnson <[email protected]>",
3737
"license": "MIT",
3838
"dependencies": {
39-
"@fortawesome/fontawesome-svg-core": "^1.3.0",
40-
"@fortawesome/free-regular-svg-icons": "^6.0.0",
41-
"@fortawesome/free-solid-svg-icons": "^6.0.0",
39+
"@fortawesome/fontawesome-svg-core": "1.2.36",
40+
"@fortawesome/free-regular-svg-icons": "^5.15.4",
41+
"@fortawesome/free-solid-svg-icons": "^5.15.4",
4242
"@fortawesome/react-fontawesome": "^0.1.17",
4343
"base64-js": "^1.5.1",
4444
"color": "^4.2.1",

components/dash-core-components/src/fragments/Graph.react.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import React, {Component} from 'react';
2-
import ResizeDetector from 'react-resize-detector';
2+
// /build/withPolyfill for IE11 support - https://github.com/maslianok/react-resize-detector/issues/144
3+
import ResizeDetector from 'react-resize-detector/build/withPolyfill';
34
import {
45
equals,
56
filter,

components/dash-table/package-lock.json

Lines changed: 33 additions & 33 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

components/dash-table/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,9 @@
4848
"@babel/polyfill": "^7.12.1",
4949
"@babel/preset-env": "^7.16.11",
5050
"@babel/preset-react": "^7.16.7",
51-
"@fortawesome/fontawesome-svg-core": "^1.3.0",
52-
"@fortawesome/free-regular-svg-icons": "^6.0.0",
53-
"@fortawesome/free-solid-svg-icons": "^6.0.0",
51+
"@fortawesome/fontawesome-svg-core": "1.2.36",
52+
"@fortawesome/free-regular-svg-icons": "^5.15.4",
53+
"@fortawesome/free-solid-svg-icons": "^5.15.4",
5454
"@fortawesome/react-fontawesome": "^0.1.17",
5555
"@percy/storybook": "^3.3.1",
5656
"@plotly/dash-component-plugins": "^1.2.2",

components/dash-table/src/dash-table/components/Table/Table.less

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -703,11 +703,10 @@
703703
}
704704
.column-actions {
705705
display: flex;
706-
flex-wrap: wrap;
707706
}
708707

709708
.column-header-name {
710-
margin-left: auto;
709+
flex-grow: 1;
711710
}
712711

713712
[class^='column-header--'], [class^='dash-filter--'] {

components/dash-table/src/dash-table/components/Table/style.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// NOTE: need to pin fontawesome-svg-core to <1.3 and free-*-svg-icons to <6
2+
// or we break IE11
13
import {library} from '@fortawesome/fontawesome-svg-core';
24
import {faEyeSlash, faTrashAlt} from '@fortawesome/free-regular-svg-icons';
35
import {

components/dash-table/tests/selenium/test_column.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ def get_app(props=dict()):
2020
baseProps["filter_action"] = "native"
2121
baseProps["merge_duplicate_headers"] = True
2222

23+
# first col is normally only 60px, make it wider since we're adding
24+
# all these actions and need to interact with them
25+
baseProps["style_cell_conditional"][0].update(width=120, maxWidth=120, minWidth=120)
2326
baseProps.update(props)
2427

2528
app.layout = DataTable(**baseProps)

0 commit comments

Comments
 (0)