[TEST] Remove cassert

Signed-off-by: Hanno Becker <[email protected]>

Author: hanno-becker

mldsa/polyvec.c

@@ -6,7 +6,6 @@
 #include <string.h>
 
 #include "common.h"
-#include "debug.h"
 #include "poly.h"
 #include "polyvec.h"
 
@@ -270,21 +269,7 @@ void mld_polyvecl_pointwise_acc_montgomery(mld_poly *w, const mld_polyvecl *u,
       t += (int64_t)u->vec[j].coeffs[i] * v->vec[j].coeffs[i];
     }
 
-    /* Substitute j == MLSDA_L into the loop invariant to get... */
-    mld_assert(j == MLDSA_L);
-    mld_assert(t >= -(int64_t)MLDSA_L * (MLDSA_Q - 1) * (MLD_NTT_BOUND - 1));
-    mld_assert(t <= (int64_t)MLDSA_L * (MLDSA_Q - 1) * (MLD_NTT_BOUND - 1));
-
-    /* ...and therefore... */
-    mld_assert(t >= -MONTGOMERY_REDUCE_STRONG_DOMAIN_MAX);
-    mld_assert(t < MONTGOMERY_REDUCE_STRONG_DOMAIN_MAX);
-
-    /* ...which meets the "strong" case of mld_montgomery_reduce() */
     r = mld_montgomery_reduce(t);
-
-    /* ...and therefore we can assert a stronger bound on r */
-    mld_assert(r > -MLDSA_Q);
-    mld_assert(r < MLDSA_Q);
     w->coeffs[i] = r;
   }
 }

mldsa/rounding.c

@@ -4,7 +4,6 @@
  */
 #include <stdint.h>
 
-#include "debug.h"
 #include "rounding.h"
 
 
@@ -18,20 +17,15 @@ void mld_decompose(int32_t *a0, int32_t *a1, int32_t a)
 {
   *a1 = (a + 127) >> 7;
   /* We know a >= 0 and a < MLDSA_Q, so... */
-  mld_assert(*a1 >= 0 && *a1 <= 65472);
 
 #if MLDSA_MODE == 2
   *a1 = (*a1 * 11275 + (1 << 23)) >> 24;
-  mld_assert(*a1 >= 0 && *a1 <= 44);
 
   *a1 ^= ((43 - *a1) >> 31) & *a1;
-  mld_assert(*a1 >= 0 && *a1 <= 43);
-#else /* MLDSA_MODE == 2 */
+#else
   *a1 = (*a1 * 1025 + (1 << 21)) >> 22;
-  mld_assert(*a1 >= 0 && *a1 <= 16);
 
   *a1 &= 15;
-  mld_assert(*a1 >= 0 && *a1 <= 15);
 
 #endif /* MLDSA_MODE != 2 */