renderToPipeableStream: expose errors through onError, no longer emit un-catchable error event on internal stream (#405)

Author: f0x52

.changeset/mighty-keys-admire.md

@@ -0,0 +1,5 @@
+---
+'preact-render-to-string': patch
+---
+
+renderToPipeableStream: expose errors through onError, no longer emit un-catchable error event on internal stream

src/stream-node.d.ts

@@ -8,7 +8,7 @@ interface RenderToPipeableStreamOptions {
 }
 
 interface PipeableStream {
-	abort: () => void;
+	abort: (reason?: unknown) => void;
 	pipe: (writable: WritableStream) => void;
 }
 

src/stream-node.js

@@ -44,17 +44,28 @@ export function renderToPipeableStream(vnode, options, context) {
 			stream.end();
 		})
 		.catch((error) => {
-			stream.destroy(error);
+			stream.destroy();
+			if (options.onError) {
+				options.onError(error);
+			} else {
+				throw error;
+			}
 		});
 
 	Promise.resolve().then(() => {
 		options.onShellReady && options.onShellReady();
 	});
 
 	return {
-		abort() {
+		/**
+		 * @param {unknown} [reason]
+		 */
+		abort(reason = new Error('The render was aborted by the server without a reason.')) {
 			controller.abort();
-			stream.destroy(new Error('aborted'));
+			stream.destroy();
+			if (options.onError) {
+				options.onError(reason);
+			}
 		},
 		/**
 		 * @param {import("stream").Writable} writable