Add semantic warning logic for non-deterministic CTE reuse

:wq
:wq

Author: Karthik Krishnaswamy

presto-cli/src/main/java/com/facebook/presto/cli/Console.java

@@ -17,6 +17,7 @@
 import com.facebook.airlift.log.LoggingConfiguration;
 import com.facebook.presto.cli.ClientOptions.OutputFormat;
 import com.facebook.presto.client.ClientSession;
+import com.facebook.presto.spi.PrestoWarning;
 import com.facebook.presto.spi.security.SelectedRole;
 import com.facebook.presto.sql.parser.StatementSplitter;
 import com.google.common.annotations.VisibleForTesting;
@@ -37,6 +38,7 @@
 import java.io.IOException;
 import java.io.PrintStream;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import java.util.Optional;
 import java.util.concurrent.CountDownLatch;
@@ -316,6 +318,19 @@ private static boolean process(QueryRunner queryRunner, String sql, OutputFormat
 
         try (Query query = queryRunner.startQuery(finalSql)) {
             boolean success = query.renderOutput(System.out, outputFormat, interactive);
+            try {
+                List<PrestoWarning> warnings = query.getWarnings();
+                if (warnings != null && !warnings.isEmpty()) {
+                    for (PrestoWarning warning : warnings) {
+                        System.err.println("WARNING: " + warning.getMessage());
+                    }
+                }
+            }
+            catch (Exception e) {
+                System.err.println("Failed to retrieve warnings: " + e.getMessage());
+            }
+
+        }
 
             ClientSession session = queryRunner.getSession();
 

presto-cli/src/main/java/com/facebook/presto/cli/Query.java

@@ -58,6 +58,15 @@ public class Query
     private final AtomicBoolean ignoreUserInterrupt = new AtomicBoolean();
     private final StatementClient client;
     private final boolean debug;
+    private final List<PrestoWarning> warnings;
+    public Query(StatementClient client, boolean debug, boolean runtime) {
+        this.client = requireNonNull(client, "client is null");
+        this.debug = debug;
+        this.runtime = runtime;
+        this.warnings = client.getWarnings();
+    }
+
+
     private final boolean runtime;
     private Optional<Long> clientStopTimestamp = Optional.empty();
 
@@ -409,6 +418,9 @@ private static void renderErrorLocation(String query, ErrorLocation location, Pr
         }
     }
 
+    public PrestoWarning[] getWarnings() {
+    }
+
     private static class PrintStreamWarningsPrinter
             extends AbstractWarningsPrinter
     {

presto-client/src/main/java/com/facebook/presto/client/QueryResults.java

@@ -33,8 +33,7 @@
 
 @Immutable
 public class QueryResults
-        implements QueryStatusInfo, QueryData
-{
+        implements QueryStatusInfo, QueryData {
     private final String id;
     private final URI infoUri;
     private final URI partialCancelUri;
@@ -48,6 +47,7 @@ public class QueryResults
     private final String updateType;
     private final Long updateCount;
 
+
     @JsonCreator
     public QueryResults(
             @JsonProperty("id") String id,
@@ -61,8 +61,7 @@ public QueryResults(
             @JsonProperty("error") QueryError error,
             @JsonProperty("warnings") List<PrestoWarning> warnings,
             @JsonProperty("updateType") String updateType,
-            @JsonProperty("updateCount") Long updateCount)
-    {
+            @JsonProperty("updateCount") Long updateCount) {
         this(
                 id,
                 infoUri,
@@ -90,8 +89,7 @@ public QueryResults(
             QueryError error,
             List<PrestoWarning> warnings,
             String updateType,
-            Long updateCount)
-    {
+            Long updateCount) {
         this.id = requireNonNull(id, "id is null");
         this.infoUri = requireNonNull(infoUri, "infoUri is null");
         this.partialCancelUri = partialCancelUri;
@@ -219,6 +217,7 @@ public List<PrestoWarning> getWarnings()
         return warnings;
     }
 
+
     /**
      * Returns the update type, if any, of the query as determined by the Analyzer
      * Could be INSERT, DELETE, CREATE, etc.

presto-client/src/main/java/com/facebook/presto/client/StatementClient.java

@@ -14,11 +14,13 @@
 package com.facebook.presto.client;
 
 import com.facebook.presto.common.type.TimeZoneKey;
+import com.facebook.presto.spi.PrestoWarning;
 import com.facebook.presto.spi.security.SelectedRole;
 
 import javax.annotation.Nullable;
 
 import java.io.Closeable;
+import java.util.List;
 import java.util.Map;
 import java.util.Optional;
 import java.util.Set;
@@ -39,13 +41,16 @@ public interface StatementClient
     boolean isFinished();
 
     StatementStats getStats();
+    List<PrestoWarning> getWarnings();
+
 
     QueryStatusInfo currentStatusInfo();
 
     QueryData currentData();
 
     QueryStatusInfo finalStatusInfo();
 
+
     Optional<String> getSetCatalog();
 
     Optional<String> getSetSchema();

presto-client/src/main/java/com/facebook/presto/client/StatementClientV1.java

@@ -16,9 +16,12 @@
 import com.facebook.airlift.json.JsonCodec;
 import com.facebook.presto.client.OkHttpUtil.NullCallback;
 import com.facebook.presto.common.type.TimeZoneKey;
+import com.facebook.presto.spi.PrestoWarning;
 import com.facebook.presto.spi.security.SelectedRole;
 import com.google.common.base.Joiner;
 import com.google.common.base.Splitter;
+import com.facebook.presto.client.QueryResults;
+import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.ImmutableSet;
 import io.airlift.units.Duration;
@@ -98,6 +101,7 @@ class StatementClientV1
 
     private final OkHttpClient httpClient;
     private final String query;
+    private List<PrestoWarning> warnings = ImmutableList.of();
     private final AtomicReference<QueryResults> currentResults = new AtomicReference<>();
     private final AtomicReference<String> setCatalog = new AtomicReference<>();
     private final AtomicReference<String> setSchema = new AtomicReference<>();
@@ -134,7 +138,9 @@ public StatementClientV1(OkHttpClient httpClient, ClientSession session, String
 
         Request request = buildQueryRequest(session, query);
 
-        JsonResponse<QueryResults> response = JsonResponse.execute(QUERY_RESULTS_CODEC, httpClient, request);
+        JsonResponse<com.facebook.presto.client.QueryResults> response = JsonResponse.execute(QUERY_RESULTS_CODEC, httpClient, request);
+        System.err.println("RAW RESPONSE BODY:");
+        System.err.println(response.getResponseBody());
         if ((response.getStatusCode() != HTTP_OK) || !response.hasValue()) {
             state.compareAndSet(State.RUNNING, State.CLIENT_ERROR);
             throw requestFailedException("starting query", request, response);
@@ -492,6 +498,10 @@ private void processResponse(Headers headers, QueryResults results)
         }
 
         currentResults.set(results);
+        results = currentResults.get();
+        if (results != null && results.getWarnings() != null) {
+            this.warnings = results.getWarnings();
+        }
     }
 
     private RuntimeException requestFailedException(String task, Request request, JsonResponse<QueryResults> response)
@@ -526,6 +536,11 @@ public void cancelLeafStage()
             httpDelete(uri);
         }
     }
+    @Override
+    public List<PrestoWarning> getWarnings()
+    {
+        return warnings;
+    }
 
     @Override
     public void close()

presto-hive/src/test/java/com/facebook/presto/hive/HiveQueryRunner.java

@@ -46,11 +46,7 @@
 import java.net.URI;
 import java.nio.file.Path;
 import java.nio.file.Paths;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.Optional;
+import java.util.*;
 import java.util.function.BiFunction;
 
 import static com.facebook.airlift.log.Level.ERROR;
@@ -464,6 +460,8 @@ public static Session createMaterializeExchangesSession(Optional<SelectedRole> r
     public static void main(String[] args)
             throws Exception
     {
+        TimeZone.setDefault(TimeZone.getTimeZone("America/Bahia_Banderas"));
+        System.out.println("JVM timezone = " + java.util.TimeZone.getDefault().getID());
         // You need to add "--user user" to your CLI for your queries to work
         setupLogging();
         Optional<Path> dataDirectory;