[pos][native] Use okhttp instead of airlift.http in pos native

Author: shrinidhijoshi

presto-spark-base/pom.xml

@@ -14,6 +14,8 @@
         <air.main.basedir>${project.parent.basedir}</air.main.basedir>
         <air.check.skip-modernizer>true</air.check.skip-modernizer>
         <dep.jetty.version>9.4.55.v20240627</dep.jetty.version>
+        <dep.okhttp.version>4.12.0</dep.okhttp.version>
+        <dep.okio-jvm.version>3.9.1</dep.okio-jvm.version>
     </properties>
 
     <dependencyManagement>
@@ -26,16 +28,6 @@
                 <type>pom</type>
                 <scope>import</scope>
             </dependency>
-            <dependency>
-                <groupId>com.facebook.airlift</groupId>
-                <artifactId>http-client</artifactId>
-                <version>0.216</version>
-            </dependency>
-            <dependency>
-                <groupId>com.facebook.airlift</groupId>
-                <artifactId>http-server</artifactId>
-                <version>0.216</version>
-            </dependency>
             <dependency>
                 <groupId>com.facebook.airlift</groupId>
                 <artifactId>event</artifactId>
@@ -51,16 +43,6 @@
                 <artifactId>drift-codec</artifactId>
                 <version>1.46</version>
             </dependency>
-            <dependency>
-                <groupId>com.facebook.drift</groupId>
-                <artifactId>drift-client</artifactId>
-                <version>1.46</version>
-            </dependency>
-            <dependency>
-                <groupId>com.facebook.drift</groupId>
-                <artifactId>drift-transport-spi</artifactId>
-                <version>1.46</version>
-            </dependency>
         </dependencies>
     </dependencyManagement>
 
@@ -132,15 +114,6 @@
             </exclusions>
         </dependency>
 
-        <dependency>
-            <groupId>com.facebook.drift</groupId>
-            <artifactId>drift-transport-spi</artifactId>
-        </dependency>
-
-        <dependency>
-            <groupId>com.facebook.drift</groupId>
-            <artifactId>drift-client</artifactId>
-        </dependency>
         <dependency>
             <groupId>com.facebook.presto</groupId>
             <artifactId>presto-expressions</artifactId>
@@ -177,20 +150,15 @@
         </dependency>
 
         <dependency>
-            <groupId>com.facebook.airlift</groupId>
-            <artifactId>http-client</artifactId>
-        </dependency>
-
-        <dependency>
-            <groupId>com.facebook.airlift</groupId>
-            <artifactId>http-server</artifactId>
-            <scope>provided</scope>
+            <groupId>com.squareup.okhttp3</groupId>
+            <artifactId>okhttp</artifactId>
+            <version>${dep.okhttp.version}</version>
         </dependency>
 
         <dependency>
-            <groupId>com.facebook.airlift</groupId>
-            <artifactId>event</artifactId>
-            <scope>provided</scope>
+            <groupId>com.squareup.okio</groupId>
+            <artifactId>okio-jvm</artifactId>
+            <version>${dep.okio-jvm.version}</version>
         </dependency>
 
         <dependency>
@@ -295,6 +263,10 @@
             <artifactId>commons-text</artifactId>
         </dependency>
 
+        <dependency>
+            <groupId>org.apache.httpcomponents</groupId>
+            <artifactId>httpcore</artifactId>
+        </dependency>
         <!-- needed by tests at runtime -->
         <dependency>
             <groupId>javax.ws.rs</groupId>
@@ -350,6 +322,10 @@
             <artifactId>presto-hive</artifactId>
             <scope>test</scope>
             <exclusions>
+                <exclusion>
+                    <groupId>com.facebook.airlift</groupId>
+                    <artifactId>http-client</artifactId>
+                </exclusion>
                 <exclusion>
                     <groupId>org.xerial.snappy</groupId>
                     <artifactId>snappy-java</artifactId>
@@ -382,6 +358,14 @@
             <artifactId>presto-tests</artifactId>
             <scope>test</scope>
             <exclusions>
+                <exclusion>
+                    <groupId>com.facebook.airlift</groupId>
+                    <artifactId>http-client</artifactId>
+                </exclusion>
+                <exclusion>
+                    <groupId>com.facebook.airlift</groupId>
+                    <artifactId>http-server</artifactId>
+                </exclusion>
                 <exclusion>
                     <groupId>javax.inject</groupId>
                     <artifactId>javax.inject</artifactId>
@@ -410,6 +394,10 @@
             <artifactId>presto-function-namespace-managers</artifactId>
             <scope>test</scope>
             <exclusions>
+                <exclusion>
+                    <groupId>com.facebook.airlift</groupId>
+                    <artifactId>http-client</artifactId>
+                </exclusion>
                 <exclusion>
                     <groupId>com.google.protobuf</groupId>
                     <artifactId>protobuf-java</artifactId>
@@ -466,6 +454,7 @@
                         <ignoredNonTestScopedDependency>com.facebook.presto:presto-expressions</ignoredNonTestScopedDependency>
                         <ignoredNonTestScopedDependency>it.unimi.dsi:fastutil</ignoredNonTestScopedDependency>
                         <ignoredNonTestScopedDependency>com.facebook.airlift:log-manager</ignoredNonTestScopedDependency>
+                        <ignoredNonTestScopedDependency>com.squareup.okio:okio-jvm</ignoredNonTestScopedDependency>
                     </ignoredNonTestScopedDependencies>
                     <ignoredUnusedDeclaredDependencies>
                         <ignoredUnusedDeclaredDependency>javax.ws.rs:javax.ws.rs-api</ignoredUnusedDeclaredDependency>

presto-spark-base/src/main/java/com/facebook/presto/spark/execution/http/OkHttpBaseResponse.java

@@ -0,0 +1,156 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.facebook.presto.spark.execution.http;
+
+import com.facebook.airlift.json.JsonCodec;
+import com.facebook.presto.spark.execution.http.server.smile.BaseResponse;
+import com.google.common.collect.ImmutableListMultimap;
+import com.google.common.collect.ListMultimap;
+import okhttp3.Response;
+
+import java.io.IOException;
+import java.util.List;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Adapter class that bridges OkHttp Response to BaseResponse interface
+ */
+public class OkHttpBaseResponse<T>
+        implements BaseResponse<T>
+{
+    private final int statusCode;
+    private final ListMultimap<OkHttpHeaderName, String> headers;
+    private final T value;
+    private final byte[] responseBytes;
+    private final Exception exception;
+    private final boolean hasValue;
+
+    public OkHttpBaseResponse(Response response, JsonCodec<T> codec)
+            throws IOException
+    {
+        requireNonNull(response, "response is null");
+        requireNonNull(codec, "codec is null");
+
+        this.statusCode = response.code();
+        this.headers = buildHeaders(response);
+
+        // Calculate values first
+        T tempValue = null;
+        boolean tempHasValue = false;
+        Exception tempException = null;
+        byte[] tempResponseBytes;
+
+        if (response.body() != null) {
+            tempResponseBytes = response.body().bytes();
+            if (statusCode == 200 && tempResponseBytes.length > 0) {
+                try {
+                    tempValue = codec.fromBytes(tempResponseBytes);
+                    tempHasValue = true;
+                    tempException = null;
+                }
+                catch (Exception e) {
+                    tempValue = null;
+                    tempHasValue = false;
+                    tempException = e;
+                }
+            }
+            else {
+                tempValue = null;
+                tempHasValue = false;
+                tempException = null;
+            }
+        }
+        else {
+            tempResponseBytes = new byte[0];
+            tempValue = null;
+            tempHasValue = false;
+            tempException = null;
+        }
+
+        // Assign to final fields only once
+        this.responseBytes = tempResponseBytes;
+        this.value = tempValue;
+        this.hasValue = tempHasValue;
+        this.exception = tempException;
+    }
+
+    private static ListMultimap<OkHttpHeaderName, String> buildHeaders(Response response)
+    {
+        ImmutableListMultimap.Builder<OkHttpHeaderName, String> builder = ImmutableListMultimap.builder();
+
+        for (String name : response.headers().names()) {
+            for (String value : response.headers().values(name)) {
+                builder.put(OkHttpHeaderName.of(name), value);
+            }
+        }
+
+        return builder.build();
+    }
+
+    @Override
+    public int getStatusCode()
+    {
+        return statusCode;
+    }
+
+    @Override
+    public String getHeader(String name)
+    {
+        List<String> values = getHeaders(name);
+        return values.isEmpty() ? null : values.get(0);
+    }
+
+    @Override
+    public List<String> getHeaders(String name)
+    {
+        return headers.get(OkHttpHeaderName.of(name));
+    }
+
+    @Override
+    public ListMultimap<OkHttpHeaderName, String> getHeaders()
+    {
+        return headers;
+    }
+
+    @Override
+    public boolean hasValue()
+    {
+        return hasValue;
+    }
+
+    @Override
+    public T getValue()
+    {
+        return value;
+    }
+
+    @Override
+    public int getResponseSize()
+    {
+        return responseBytes.length;
+    }
+
+    @Override
+    public byte[] getResponseBytes()
+    {
+        return responseBytes;
+    }
+
+    @Override
+    public Exception getException()
+    {
+        return exception;
+    }
+}

presto-spark-base/src/main/java/com/facebook/presto/spark/execution/http/OkHttpHeaderName.java

@@ -0,0 +1,59 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.facebook.presto.spark.execution.http;
+
+import java.util.Objects;
+
+/**
+ * A replacement for airlift HeaderName that works with OkHttp
+ */
+public class OkHttpHeaderName
+{
+    private final String name;
+
+    private OkHttpHeaderName(String name)
+    {
+        this.name = name.toLowerCase();
+    }
+
+    public static OkHttpHeaderName of(String name)
+    {
+        return new OkHttpHeaderName(name);
+    }
+
+    @Override
+    public String toString()
+    {
+        return name;
+    }
+
+    @Override
+    public boolean equals(Object o)
+    {
+        if (this == o) {
+            return true;
+        }
+        if (o == null || getClass() != o.getClass()) {
+            return false;
+        }
+        OkHttpHeaderName that = (OkHttpHeaderName) o;
+        return Objects.equals(name, that.name);
+    }
+
+    @Override
+    public int hashCode()
+    {
+        return Objects.hash(name);
+    }
+}

presto-spark-base/src/main/java/com/facebook/presto/spark/execution/http/OkHttpResponseHandler.java

@@ -0,0 +1,25 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.facebook.presto.spark.execution.http;
+
+import com.facebook.presto.spark.execution.http.server.smile.BaseResponse;
+import okhttp3.Request;
+import okhttp3.Response;
+
+import java.io.IOException;
+
+public interface OkHttpResponseHandler<T>
+{
+    BaseResponse<T> handle(Request request, Response response) throws IOException;
+}