Skip to content

refactor: Prepare for Velox replacing folly::Optional with std::optional #25789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbasmanova wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: Prepare for Velox replacing folly::Optional with std::optional #25789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/main/common/Configs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ folly::Optional<std::string> ConfigBase::setValue(
auto oldValue = config_->get<std::string>(propertyName);
config_->set(propertyName, value);
if (oldValue.has_value()) {
return oldValue;
return oldValue.value();
}
return registeredProps_[propertyName];
}
Expand Down
2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/main/common/Configs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ class ConfigBase {
const std::string& propertyName) const {
auto val = config_->get<std::string>(propertyName);
if (val.has_value()) {
return val;
return val.value();
}
const auto it = registeredProps_.find(propertyName);
if (it != registeredProps_.end()) {
Expand Down
Loading