Allow setting fixed first properties to be sorted first #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Hi @Thodor12 — thanks for the contribution, but I think this is one of those features we will be opinionated about and not support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new option called
xmlSortAttributesFirst, this allows to sort attributes in a fixed way.For example if I were to have an
idfield on my XML and I always want this attribute to be sorted first, I can putxmlSortAttributesFirst: ["id"]to force this property to come first.The attributes in this list are sorted in the order they are listed, even if certain are not present.
I've added 2 tests to ensure the functionality works as intended.