-
Notifications
You must be signed in to change notification settings - Fork 128
Update shared personal token to use a generated primer app token #3777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request modernizes the static files workflow by transitioning from a shared personal access token to a GitHub App token for authentication. This change improves security and allows the workflow to run on all pushes (not just the main branch) since GitHub App tokens don't trigger additional CI workflows like personal access tokens do.
Key changes:
- Replaced static personal access token (
GPR_AUTH_TOKEN_SHARED) with dynamically generated GitHub App token - Removed branch restriction to enable workflow execution on all pushes
- Removed outdated comment about branch protection limitations with GitHub Apps
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
llastflowers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
https://github.com/github/primer/issues/6097
What are you trying to accomplish?
This pull request updates the static files workflow to improve authentication and token management for GitHub Actions. The main change is switching to a GitHub App token for secure operations, replacing the previous use of a shared personal access token.
Risk Assessment
Anything you want to highlight for special attention from reviewers?
I think I also want to change this to always run. We had restricted it to main because the commit on a branch would block ci, but with the app that doesn't happen.