fix warnings from -Weffc++ and fix bug where BlockChunkFullLock/BlockChunkColumn weren't locking anything

Author: programmerjake

Makefile

@@ -340,8 +340,11 @@ class BlockDescriptors_t final
 
         return retval;
     }
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Weffc++"
     class iterator final : public std::iterator<std::forward_iterator_tag, const BlockDescriptorPointer>
     {
+#pragma GCC diagnostic pop
         friend class BlockDescriptors_t;
         MapType::const_iterator iter;
         bool empty;

include/block/block.h

@@ -253,9 +253,12 @@ class BlockDataPointerBase
     }
 };
 
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Weffc++"
 template <typename T>
 struct BlockDataPointer : public BlockDataPointerBase
 {
+#pragma GCC diagnostic pop
     T *get() const
     {
         return static_cast<T *>(BlockDataPointerBase::get());
@@ -360,17 +363,21 @@ struct Block final
     Lighting lighting;
     BlockDataPointer<BlockData> data;
     Block()
-        : descriptor(nullptr), data(nullptr)
+        : descriptor(nullptr), lighting(), data(nullptr)
     {
     }
     Block(BlockDescriptorPointer descriptor, BlockDataPointer<BlockData> data = nullptr)
-        : descriptor(descriptor), data(data)
+        : descriptor(descriptor), lighting(), data(data)
     {
     }
     Block(BlockDescriptorPointer descriptor, Lighting lighting, BlockDataPointer<BlockData> data = nullptr)
         : descriptor(descriptor), lighting(lighting), data(data)
     {
     }
+    Block(const Block &rt) = default;
+    Block(Block &&rt) = default;
+    Block &operator =(const Block &rt) = default;
+    Block &operator =(Block &&rt) = default;
     bool good() const
     {
         return descriptor != nullptr;
@@ -400,6 +407,9 @@ struct PackedBlock final
     BlockDataPointer<BlockData> data;
     explicit PackedBlock(const Block &b);
     PackedBlock()
+        : descriptor(),
+        lighting(),
+        data()
     {
     }
     explicit operator Block() const

include/block/block_struct.h

@@ -52,7 +52,9 @@ class DirtBlock : public FullBlock
                     RayCasting::BlockCollisionMaskGround,
                     isFaceBlockedNX, isFaceBlockedPX,
                     isFaceBlockedNY, isFaceBlockedPY,
-                    isFaceBlockedNZ, isFaceBlockedPZ)
+                    isFaceBlockedNZ, isFaceBlockedPZ),
+        meshGrassFace(),
+        meshGrassCenter()
     {
         meshFace[BlockFace::NX] = makeFaceMeshNX(nxDirt);
         meshFace[BlockFace::PX] = makeFaceMeshPX(pxDirt);

include/block/builtin/dirt_block.h

@@ -51,17 +51,27 @@ namespace builtin
 
 class Furnace final : public FullBlock
 {
+    Furnace(const Furnace &) = delete;
+    Furnace &operator =(const Furnace &) = delete;
     friend class ui::builtin::FurnaceUi;
 private:
     struct FurnaceData final
     {
-        std::atomic_bool hasEntity = {false};
+        std::atomic_bool hasEntity;
         std::recursive_mutex lock;
         ItemStack outputStack;
         ItemStack inputStack;
         ItemStack fuelStack;
         float burnTimeLeft = 0.0f;
         float currentElapsedSmeltTime = 0.0f;
+        FurnaceData()
+            : hasEntity(false),
+            lock(),
+            outputStack(),
+            inputStack(),
+            fuelStack()
+        {
+        }
         unsigned transferToFuelStack(ItemStack &sourceStack, unsigned transferCount)
         {
             if(!sourceStack.good())
@@ -263,6 +273,7 @@ class Furnace final : public FullBlock
     {
         enum_array<enum_array<Furnace *, bool>, BlockFace> furnaces;
         FurnaceMaker()
+            : furnaces()
         {
             for(BlockFace facing : enum_traits<BlockFace>())
             {

include/block/builtin/furnace.h

@@ -261,6 +261,7 @@ class RedstoneDust final : public AttachedBlock
         checked_array<enum_array<enum_array<enum_array<enum_array<const RedstoneDust *, EdgeAttachedState>, EdgeAttachedState>, EdgeAttachedState>, EdgeAttachedState>, RedstoneSignal::maxSignalStrength + 1> descriptors;
     public:
         RedstoneDustConstructor()
+            : descriptors()
         {
             for(int signalStrength = 0; signalStrength <= RedstoneSignal::maxSignalStrength; signalStrength++)
             {
@@ -550,6 +551,7 @@ class RedstoneTorch final : public GenericTorch
         enum_array<enum_array<RedstoneTorch *, bool>, BlockFace> torches;
     public:
         RedstoneTorchInstanceMaker()
+            : torches()
         {
             for(BlockFace bf : enum_traits<BlockFace>())
             {

include/block/builtin/redstone.h

@@ -246,6 +246,7 @@ class Torch final : public GenericTorch
         enum_array<Torch *, BlockFace> torches;
     public:
         TorchInstanceMaker()
+            : torches()
         {
             for(BlockFace bf : enum_traits<BlockFace>())
             {

include/block/builtin/torch.h

@@ -42,6 +42,7 @@ class Water : public Fluid
         friend class global_instance_maker<WaterConstructor>;
         checked_array<checked_array<Water *, 8>, 2> descriptors;
         WaterConstructor()
+            : descriptors()
         {
             for(int falling = 0; falling <= 1; falling++)
             {

include/block/builtin/water.h

@@ -40,6 +40,8 @@ namespace builtin
 {
 class WoodLog : public FullBlock
 {
+    WoodLog(const WoodLog &) = delete;
+    WoodLog &operator =(const WoodLog &) = delete;
 protected:
     const WoodDescriptorPointer woodDescriptor;
     const LogOrientation logOrientation;
@@ -158,6 +160,8 @@ class WoodLog : public FullBlock
 
 class WoodPlanks : public FullBlock
 {
+    WoodPlanks(const WoodPlanks &) = delete;
+    WoodPlanks &operator =(const WoodPlanks &) = delete;
 protected:
     const WoodDescriptorPointer woodDescriptor;
     static std::wstring makeName(WoodDescriptorPointer woodDescriptor)
@@ -206,6 +210,8 @@ class WoodPlanks : public FullBlock
 
 class WoodLeaves : public FullBlock
 {
+    WoodLeaves(const WoodLeaves &) = delete;
+    WoodLeaves &operator =(const WoodLeaves &) = delete;
 protected:
     const WoodDescriptorPointer woodDescriptor;
     const bool canDecay;
@@ -322,8 +328,14 @@ class WoodLeaves : public FullBlock
     }
 public:
     WoodLeaves(WoodDescriptorPointer woodDescriptor, bool canDecay)
-        : FullBlock(makeName(woodDescriptor, canDecay), LightProperties(Lighting(), Lighting::makeDirectOnlyLighting()), RayCasting::BlockCollisionMaskGround,
-                    false, false, false, false, false, false), woodDescriptor(woodDescriptor), canDecay(canDecay)
+        : FullBlock(makeName(woodDescriptor, canDecay),
+                    LightProperties(Lighting(),
+                                    Lighting::makeDirectOnlyLighting()),
+                    RayCasting::BlockCollisionMaskGround,
+                    false, false, false, false, false, false),
+        woodDescriptor(woodDescriptor),
+        canDecay(canDecay),
+        meshBlockedFace()
     {
         TextureDescriptor td = woodDescriptor->getLeavesTexture();
         meshFace[BlockFace::NX] = makeFaceMeshNX(td);
@@ -460,6 +472,8 @@ class WoodLeaves : public FullBlock
 
 class Sapling : public Plant
 {
+    Sapling(const Sapling &) = delete;
+    Sapling &operator =(const Sapling &) = delete;
 protected:
     const WoodDescriptorPointer woodDescriptor;
     static std::wstring makeName(WoodDescriptorPointer woodDescriptor, unsigned frame)

include/block/builtin/wood.h

@@ -88,7 +88,7 @@ class OggVorbisDecoder final : public AudioDecoder
     }
 public:
     OggVorbisDecoder(std::shared_ptr<stream::Reader> reader)
-        : reader(reader)
+        : ovf(), reader(reader), samples(), channels(), sampleRate(), buffer()
     {
         ov_callbacks callbacks;
         callbacks.read_func = &read_fn;