Skip to content

Commit 3c7edb0

Browse files
Update e2e readme wrt secure parameter used for minio client in mnist script
1 parent f472620 commit 3c7edb0

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

docs/e2e.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,3 +130,4 @@ Currently the SDK doesn't support tolerations, so e2e tests can't be executed on
130130
AWS_STORAGE_BUCKET=<storage-bucket-name>
131131
AWS_STORAGE_BUCKET_MNIST_DIR=<storage-bucket-MNIST-datasets-directory>
132132
```
133+
Note : When using the Python Minio client to connect to a minio storage bucket, the `AWS_DEFAULT_ENDPOINT` environment variable by default expects secure endpoint where user can use endpoint url with https/http prefix for autodetection of secure/insecure endpoint.

tests/e2e/mnist.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,9 +154,10 @@ def prepare_data(self):
154154
secret_key = os.environ.get("AWS_SECRET_ACCESS_KEY")
155155
bucket_name = os.environ.get("AWS_STORAGE_BUCKET")
156156

157+
# remove prefix if specified in storage bucket endpoint url
158+
secure = True
157159
if endpoint.startswith("https://"):
158160
endpoint = endpoint[len("https://") :]
159-
secure = True
160161
elif endpoint.startswith("http://"):
161162
endpoint = endpoint[len("http://") :]
162163
secure = False

0 commit comments

Comments
 (0)