Skip to content

Commit 8b4e909

Browse files
committed
chore: ignore jupyter notebooks from codecov
1 parent f33353e commit 8b4e909

File tree

2 files changed

+30
-4
lines changed

2 files changed

+30
-4
lines changed

codecov.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
ignore:
2+
- "**/*.ipynb"
3+
- "demo-notebooks/**"

demo-notebooks/additional-demos/batch-inference/remote_offline_bi.ipynb

Lines changed: 27 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
},
1313
{
1414
"cell_type": "code",
15-
"execution_count": 4,
15+
"execution_count": 1,
1616
"metadata": {},
1717
"outputs": [],
1818
"source": [
@@ -25,9 +25,32 @@
2525
},
2626
{
2727
"cell_type": "code",
28-
"execution_count": 6,
28+
"execution_count": 2,
2929
"metadata": {},
30-
"outputs": [],
30+
"outputs": [
31+
{
32+
"ename": "ValueError",
33+
"evalue": "Invalid gcs_address: XXXX",
34+
"output_type": "error",
35+
"traceback": [
36+
"\u001b[31m---------------------------------------------------------------------------\u001b[39m",
37+
"\u001b[31mValueError\u001b[39m Traceback (most recent call last)",
38+
"\u001b[36mFile \u001b[39m\u001b[32mpython/ray/includes/common.pxi:53\u001b[39m, in \u001b[36mray._raylet.GcsClientOptions.create\u001b[39m\u001b[34m()\u001b[39m\n",
39+
"\u001b[31mValueError\u001b[39m: need more than 1 value to unpack",
40+
"\nDuring handling of the above exception, another exception occurred:\n",
41+
"\u001b[31mValueError\u001b[39m Traceback (most recent call last)",
42+
"\u001b[36mCell\u001b[39m\u001b[36m \u001b[39m\u001b[32mIn[2]\u001b[39m\u001b[32m, line 5\u001b[39m\n\u001b[32m 2\u001b[39m ray_dashboard = \u001b[33m\"\u001b[39m\u001b[33mXXXX\u001b[39m\u001b[33m\"\u001b[39m \u001b[38;5;66;03m# Replace with the Ray dashboard URL\u001b[39;00m\n\u001b[32m 4\u001b[39m \u001b[38;5;66;03m# Initialize the RayJobClient\u001b[39;00m\n\u001b[32m----> \u001b[39m\u001b[32m5\u001b[39m client = \u001b[43mRayJobClient\u001b[49m\u001b[43m(\u001b[49m\u001b[43maddress\u001b[49m\u001b[43m=\u001b[49m\u001b[43mray_dashboard\u001b[49m\u001b[43m,\u001b[49m\u001b[43m \u001b[49m\u001b[43mheaders\u001b[49m\u001b[43m=\u001b[49m\u001b[43mheader\u001b[49m\u001b[43m,\u001b[49m\u001b[43m \u001b[49m\u001b[43mverify\u001b[49m\u001b[43m=\u001b[49m\u001b[38;5;28;43;01mTrue\u001b[39;49;00m\u001b[43m)\u001b[49m\n",
43+
"\u001b[36mFile \u001b[39m\u001b[32m~/Code/github.com/codeflare-sdk/.venv/lib/python3.11/site-packages/codeflare_sdk/ray/client/ray_jobs.py:60\u001b[39m, in \u001b[36mRayJobClient.__init__\u001b[39m\u001b[34m(self, address, create_cluster_if_needed, cookies, metadata, headers, verify)\u001b[39m\n\u001b[32m 51\u001b[39m \u001b[38;5;28;01mdef\u001b[39;00m\u001b[38;5;250m \u001b[39m\u001b[34m__init__\u001b[39m(\n\u001b[32m 52\u001b[39m \u001b[38;5;28mself\u001b[39m,\n\u001b[32m 53\u001b[39m address: Optional[\u001b[38;5;28mstr\u001b[39m] = \u001b[38;5;28;01mNone\u001b[39;00m,\n\u001b[32m (...)\u001b[39m\u001b[32m 58\u001b[39m verify: Optional[Union[\u001b[38;5;28mstr\u001b[39m, \u001b[38;5;28mbool\u001b[39m]] = \u001b[38;5;28;01mTrue\u001b[39;00m,\n\u001b[32m 59\u001b[39m ):\n\u001b[32m---> \u001b[39m\u001b[32m60\u001b[39m \u001b[38;5;28mself\u001b[39m.rayJobClient = \u001b[43mJobSubmissionClient\u001b[49m\u001b[43m(\u001b[49m\n\u001b[32m 61\u001b[39m \u001b[43m \u001b[49m\u001b[43maddress\u001b[49m\u001b[43m=\u001b[49m\u001b[43maddress\u001b[49m\u001b[43m,\u001b[49m\n\u001b[32m 62\u001b[39m \u001b[43m \u001b[49m\u001b[43mcreate_cluster_if_needed\u001b[49m\u001b[43m=\u001b[49m\u001b[43mcreate_cluster_if_needed\u001b[49m\u001b[43m,\u001b[49m\n\u001b[32m 63\u001b[39m \u001b[43m \u001b[49m\u001b[43mcookies\u001b[49m\u001b[43m=\u001b[49m\u001b[43mcookies\u001b[49m\u001b[43m,\u001b[49m\n\u001b[32m 64\u001b[39m \u001b[43m \u001b[49m\u001b[43mmetadata\u001b[49m\u001b[43m=\u001b[49m\u001b[43mmetadata\u001b[49m\u001b[43m,\u001b[49m\n\u001b[32m 65\u001b[39m \u001b[43m \u001b[49m\u001b[43mheaders\u001b[49m\u001b[43m=\u001b[49m\u001b[43mheaders\u001b[49m\u001b[43m,\u001b[49m\n\u001b[32m 66\u001b[39m \u001b[43m \u001b[49m\u001b[43mverify\u001b[49m\u001b[43m=\u001b[49m\u001b[43mverify\u001b[49m\u001b[43m,\u001b[49m\n\u001b[32m 67\u001b[39m \u001b[43m \u001b[49m\u001b[43m)\u001b[49m\n",
44+
"\u001b[36mFile \u001b[39m\u001b[32m~/Code/github.com/codeflare-sdk/.venv/lib/python3.11/site-packages/ray/dashboard/modules/job/sdk.py:96\u001b[39m, in \u001b[36mJobSubmissionClient.__init__\u001b[39m\u001b[34m(self, address, create_cluster_if_needed, cookies, metadata, headers, verify)\u001b[39m\n\u001b[32m 93\u001b[39m \u001b[38;5;28;01mif\u001b[39;00m \u001b[38;5;129;01mnot\u001b[39;00m (\u001b[38;5;28misinstance\u001b[39m(verify, \u001b[38;5;28mstr\u001b[39m) \u001b[38;5;129;01mor\u001b[39;00m \u001b[38;5;28misinstance\u001b[39m(verify, \u001b[38;5;28mbool\u001b[39m)):\n\u001b[32m 94\u001b[39m \u001b[38;5;28;01mraise\u001b[39;00m \u001b[38;5;167;01mTypeError\u001b[39;00m(\u001b[33mf\u001b[39m\u001b[33m\"\u001b[39m\u001b[33mverify must be a str or bool, got \u001b[39m\u001b[38;5;132;01m{\u001b[39;00m\u001b[38;5;28mtype\u001b[39m(verify)\u001b[38;5;132;01m}\u001b[39;00m\u001b[33m\"\u001b[39m)\n\u001b[32m---> \u001b[39m\u001b[32m96\u001b[39m api_server_url = \u001b[43mget_address_for_submission_client\u001b[49m\u001b[43m(\u001b[49m\u001b[43maddress\u001b[49m\u001b[43m)\u001b[49m\n\u001b[32m 98\u001b[39m \u001b[38;5;28msuper\u001b[39m().\u001b[34m__init__\u001b[39m(\n\u001b[32m 99\u001b[39m address=api_server_url,\n\u001b[32m 100\u001b[39m create_cluster_if_needed=create_cluster_if_needed,\n\u001b[32m (...)\u001b[39m\u001b[32m 104\u001b[39m verify=verify,\n\u001b[32m 105\u001b[39m )\n\u001b[32m 106\u001b[39m \u001b[38;5;28mself\u001b[39m._check_connection_and_version(\n\u001b[32m 107\u001b[39m min_version=\u001b[33m\"\u001b[39m\u001b[33m1.9\u001b[39m\u001b[33m\"\u001b[39m,\n\u001b[32m 108\u001b[39m version_error_message=\u001b[33m\"\u001b[39m\u001b[33mJobs API is not supported on the Ray \u001b[39m\u001b[33m\"\u001b[39m\n\u001b[32m 109\u001b[39m \u001b[33m\"\u001b[39m\u001b[33mcluster. Please ensure the cluster is \u001b[39m\u001b[33m\"\u001b[39m\n\u001b[32m 110\u001b[39m \u001b[33m\"\u001b[39m\u001b[33mrunning Ray 1.9 or higher.\u001b[39m\u001b[33m\"\u001b[39m,\n\u001b[32m 111\u001b[39m )\n",
45+
"\u001b[36mFile \u001b[39m\u001b[32m~/Code/github.com/codeflare-sdk/.venv/lib/python3.11/site-packages/ray/dashboard/utils.py:723\u001b[39m, in \u001b[36mget_address_for_submission_client\u001b[39m\u001b[34m(address)\u001b[39m\n\u001b[32m 720\u001b[39m address = ray_client_address_to_api_server_url(address)\n\u001b[32m 721\u001b[39m \u001b[38;5;28;01melse\u001b[39;00m:\n\u001b[32m 722\u001b[39m \u001b[38;5;66;03m# User specified a non-Ray-Client Ray cluster address.\u001b[39;00m\n\u001b[32m--> \u001b[39m\u001b[32m723\u001b[39m address = \u001b[43mray_address_to_api_server_url\u001b[49m\u001b[43m(\u001b[49m\u001b[43maddress\u001b[49m\u001b[43m)\u001b[49m\n\u001b[32m 724\u001b[39m logger.debug(\u001b[33mf\u001b[39m\u001b[33m\"\u001b[39m\u001b[33mUsing API server address \u001b[39m\u001b[38;5;132;01m{\u001b[39;00maddress\u001b[38;5;132;01m}\u001b[39;00m\u001b[33m.\u001b[39m\u001b[33m\"\u001b[39m)\n\u001b[32m 725\u001b[39m \u001b[38;5;28;01mreturn\u001b[39;00m address\n",
46+
"\u001b[36mFile \u001b[39m\u001b[32m~/Code/github.com/codeflare-sdk/.venv/lib/python3.11/site-packages/ray/dashboard/utils.py:672\u001b[39m, in \u001b[36mray_address_to_api_server_url\u001b[39m\u001b[34m(address)\u001b[39m\n\u001b[32m 655\u001b[39m \u001b[38;5;250m\u001b[39m\u001b[33;03m\"\"\"Parse a Ray cluster address into API server URL.\u001b[39;00m\n\u001b[32m 656\u001b[39m \n\u001b[32m 657\u001b[39m \u001b[33;03mWhen an address is provided, it will be used to query GCS for\u001b[39;00m\n\u001b[32m (...)\u001b[39m\u001b[32m 668\u001b[39m \u001b[33;03m API server HTTP URL.\u001b[39;00m\n\u001b[32m 669\u001b[39m \u001b[33;03m\"\"\"\u001b[39;00m\n\u001b[32m 671\u001b[39m address = services.canonicalize_bootstrap_address_or_die(address)\n\u001b[32m--> \u001b[39m\u001b[32m672\u001b[39m gcs_client = \u001b[43mGcsClient\u001b[49m\u001b[43m(\u001b[49m\u001b[43maddress\u001b[49m\u001b[43m=\u001b[49m\u001b[43maddress\u001b[49m\u001b[43m)\u001b[49m\n\u001b[32m 674\u001b[39m ray.experimental.internal_kv._initialize_internal_kv(gcs_client)\n\u001b[32m 675\u001b[39m api_server_url = ray._private.utils.internal_kv_get_with_retry(\n\u001b[32m 676\u001b[39m gcs_client,\n\u001b[32m 677\u001b[39m ray_constants.DASHBOARD_ADDRESS,\n\u001b[32m 678\u001b[39m namespace=ray_constants.KV_NAMESPACE_DASHBOARD,\n\u001b[32m 679\u001b[39m num_retries=\u001b[32m20\u001b[39m,\n\u001b[32m 680\u001b[39m )\n",
47+
"\u001b[36mFile \u001b[39m\u001b[32mpython/ray/_raylet.pyx:2740\u001b[39m, in \u001b[36mray._raylet.GcsClient.__cinit__\u001b[39m\u001b[34m()\u001b[39m\n",
48+
"\u001b[36mFile \u001b[39m\u001b[32mpython/ray/includes/gcs_client.pxi:56\u001b[39m, in \u001b[36mray._raylet.InnerGcsClient.standalone\u001b[39m\u001b[34m()\u001b[39m\n",
49+
"\u001b[36mFile \u001b[39m\u001b[32mpython/ray/includes/common.pxi:59\u001b[39m, in \u001b[36mray._raylet.GcsClientOptions.create\u001b[39m\u001b[34m()\u001b[39m\n",
50+
"\u001b[31mValueError\u001b[39m: Invalid gcs_address: XXXX"
51+
]
52+
}
53+
],
3154
"source": [
3255
"# Gather the dashboard URL (provided by the creator of the RayCluster)\n",
3356
"ray_dashboard = \"XXXX\" # Replace with the Ray dashboard URL\n",
@@ -206,7 +229,7 @@
206229
"name": "python",
207230
"nbconvert_exporter": "python",
208231
"pygments_lexer": "ipython3",
209-
"version": "3.11.12"
232+
"version": "3.11.13"
210233
}
211234
},
212235
"nbformat": 4,

0 commit comments

Comments
 (0)