-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[prometheus-pgbouncer-exporter] remove bitnami deps and simplify CI deps #6027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prometheus-pgbouncer-exporter] remove bitnami deps and simplify CI deps #6027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other thing with respect to Bitnami's images in this chart is the postgresql subchart (dependency) and the corresponding image which this PR does not address.
My suggestion would be to remove the dependency and the extra container from the CI configuration entirely. This would cause no problems in CI as PgBouncer exporter does not require PgBouncer to start successfully. In fact, the CI jobs do not validate nor test whether the exporter functions as expected - launching the target service in CI seems in this sense and in this case unnecessary.
|
zeritti let me try and if so ill take a look doing it more globally with other such deps (kafka, etc) |
0ef73eb to
c33f92d
Compare
|
Thanks @zeritti should be even cleaner now |
2f0212b to
7eee258
Compare
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
7eee258 to
6acc127
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PgBouncer does not start without a PostgreSQL instance to connect to leading to a failure in the CI test case. I have therefore removed the extra container hoping it is ok with you, @DrFaust92. Cheers!
What this PR does / why we need it
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])