[kube-state-metrics] align metricAnnotationsAllowlist #6134
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The difference in the name of
metricAnnotationsAllowListandmetricLabelsAllowlistis confusing and can lead to misktakes when configuring the chart. The names should therefore be aligned. The new name also matches the capitalization inmetricAllowlistandmetricDenylist.Which issue this PR fixes
Special notes for your reviewer
The change could also be made in a backwards-incompatible way to keep the chart cleaner, if you prefer.
Checklist
[prometheus-couchdb-exporter])